move view definition outside of components

woocommerce · Dec 13, 2021 · bdf9748 · bdf9748
1 parent 9ecc545
commit bdf9748
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 24 deletions.
diff --git a/assets/js/blocks/cart-checkout/cart/edit.js b/assets/js/blocks/cart-checkout/cart/edit.js
@@ -46,6 +46,19 @@ const ALLOWED_BLOCKS = [
 	'woocommerce/empty-cart-block',
 ];
 
+const views = [
+	{
+		view: 'woocommerce/filled-cart-block',
+		label: __( 'Filled Cart', 'woo-gutenberg-products-block' ),
+		icon: <Icon srcElement={ filledCart } />,
+	},
+	{
+		view: 'woocommerce/empty-cart-block',
+		label: __( 'Empty Cart', 'woo-gutenberg-products-block' ),
+		icon: <Icon srcElement={ removeCart } />,
+	},
+];
+
 const BlockSettings = ( { attributes, setAttributes } ) => {
 	const { hasDarkControls } = attributes;
 	const { currentPostId } = useEditorContext();
@@ -104,18 +117,7 @@ export const Edit = ( { className, attributes, setAttributes, clientId } ) => {
 	const { hasDarkControls } = attributes;
 	const { currentView, component: ViewSwitcherComponent } = useViewSwitcher(
 		clientId,
-		[
-			{
-				view: 'woocommerce/filled-cart-block',
-				label: __( 'Filled Cart', 'woo-gutenberg-products-block' ),
-				icon: <Icon srcElement={ filledCart } />,
-			},
-			{
-				view: 'woocommerce/empty-cart-block',
-				label: __( 'Empty Cart', 'woo-gutenberg-products-block' ),
-				icon: <Icon srcElement={ removeCart } />,
-			},
-		]
+		views
 	);
 	const defaultTemplate = [
 		[ 'woocommerce/filled-cart-block', {}, [] ],

diff --git a/assets/js/blocks/cart-checkout/mini-cart-contents/edit.tsx b/assets/js/blocks/cart-checkout/mini-cart-contents/edit.tsx
@@ -22,6 +22,20 @@ const ALLOWED_BLOCKS = [
 	'woocommerce/filled-mini-cart-contents-block',
 	'woocommerce/empty-mini-cart-contents-block',
 ];
+
+const views = [
+	{
+		view: 'woocommerce/filled-mini-cart-contents-block',
+		label: __( 'Filled Mini Cart', 'woo-gutenberg-products-block' ),
+		icon: <Icon srcElement={ filledCart } />,
+	},
+	{
+		view: 'woocommerce/empty-mini-cart-contents-block',
+		label: __( 'Empty Mini Cart', 'woo-gutenberg-products-block' ),
+		icon: <Icon srcElement={ removeCart } />,
+	},
+];
+
 interface Props {
 	clientId: string;
 }
@@ -36,18 +50,7 @@ const Edit = ( { clientId }: Props ): ReactElement => {
 
 	const { currentView, component: ViewSwitcherComponent } = useViewSwitcher(
 		clientId,
-		[
-			{
-				view: 'woocommerce/filled-mini-cart-contents-block',
-				label: __( 'Filled Mini Cart', 'woo-gutenberg-products-block' ),
-				icon: <Icon srcElement={ filledCart } />,
-			},
-			{
-				view: 'woocommerce/empty-mini-cart-contents-block',
-				label: __( 'Empty Mini Cart', 'woo-gutenberg-products-block' ),
-				icon: <Icon srcElement={ removeCart } />,
-			},
-		]
+		views
 	);
 
 	useForcedLayout( {