move view names inside useEffect

woocommerce · Dec 13, 2021 · 9ecc545 · 9ecc545
1 parent 040cec8
commit 9ecc545
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/assets/js/blocks/cart-checkout/shared/use-view-switcher.tsx b/assets/js/blocks/cart-checkout/shared/use-view-switcher.tsx
@@ -23,7 +23,6 @@ export const useViewSwitcher = (
 } => {
 	const initialView = views[ 0 ];
 	const [ currentView, setCurrentView ] = useState( initialView );
-	const viewNames = views.map( ( { view } ) => view );
 	const { selectBlock } = useDispatch( 'core/block-editor' );
 	const {
 		getBlock,
@@ -33,6 +32,7 @@ export const useViewSwitcher = (
 	const selectedBlockClientId = getSelectedBlockClientId();
 
 	useEffect( () => {
+		const viewNames = views.map( ( { view } ) => view );
 		const parentBlockIds = getBlockParentsByBlockName(
 			selectedBlockClientId,
 			viewNames
@@ -59,7 +59,6 @@ export const useViewSwitcher = (
 	}, [
 		getBlockParentsByBlockName,
 		selectedBlockClientId,
-		viewNames,
 		getBlock,
 		currentView.view,
 		views,