Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI linting issues #2041

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Fix CI linting issues #2041

merged 1 commit into from
Sep 8, 2022

Conversation

albarin
Copy link
Contributor

@albarin albarin commented Sep 8, 2022

Fixes #2004

How to test the changes in this Pull Request:

  1. Make sure every CI check is now passing in the PR.

@albarin albarin changed the title Fix php lint issues Fix CI linting issues Sep 8, 2022
@albarin albarin marked this pull request as ready for review September 8, 2022 10:20
@albarin albarin requested a review from a team as a code owner September 8, 2022 10:20
@albarin albarin requested review from Aljullu and removed request for a team September 8, 2022 10:20
Aljullu
Aljullu approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@Aljullu Aljullu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@github-actions github-actions bot added the status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging. label Sep 8, 2022
@albarin albarin merged commit 6549177 into trunk Sep 8, 2022
@albarin albarin deleted the fix/2004-fix-lints branch September 8, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aljullu Aljullu Aljullu approved these changes

Assignees
No one assigned
Labels
status: ready to merge Automatically applied to a pull when a pull is approved. Indicates ready for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP and JS automated tests fails when pushing code
2 participants
@albarin @Aljullu