Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP and JS automated tests fails when pushing code #2004

Closed
danieldudzic opened this issue Jul 1, 2022 · 0 comments · Fixed by #2041
Closed

PHP and JS automated tests fails when pushing code #2004

danieldudzic opened this issue Jul 1, 2022 · 0 comments · Fixed by #2041
Labels
type: bug The issue is a confirmed bug. type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@danieldudzic
Copy link
Contributor

When doing the 4.1.1 release, I have noticed a bunch of unrelated errors before merging the PR.

  1. Multiple instances of the same PHP error in inc/class-storefront.php:
    A hook was found, but was not accompanied by a docblock comment on the line above to clarify the meaning of the hook.

  2. JS Lint fail:
    ESLint issues detected.

  • Analyzing /home/runner/work/storefront/storefront/assets/js/woocommerce/extensions/brands.js
  • Analyzing /home/runner/work/storefront/storefront/assets/js/sticky-add-to-cart.js

It would be good to tidy this up, to make sure that new bugs won't fall through the cracks.
 
@danieldudzic danieldudzic added type: bug The issue is a confirmed bug. type: technical debt This issue/PR represents/solves the technical debt of the project. labels Jul 1, 2022
@danielwrobert danielwrobert mentioned this issue Aug 22, 2022
Merged
@albarin albarin mentioned this issue Sep 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug The issue is a confirmed bug. type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix CI linting issues woocommerce/storefront
1 participant
@danieldudzic