Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipping improvements - Phase 3 #2757

Merged
merged 29 commits into from
Jan 13, 2025
Merged

Conversation

eason9487
Copy link
Member

@eason9487 eason9487 commented Jan 9, 2025

Changes proposed in this Pull Request:

This PR gathers all changes from the following feature PRs for final testing and to be merged together into develop.

📌 Checklist before merging (@eason9487)

  • Update tracking doc

eason9487 and others added 26 commits January 2, 2025 12:16
… and the related components and functions.
…ettings.test.js`


Address: #2749 (comment)

Co-authored-by: Miguel Pérez Pellicer <[email protected]>
Move tax rate setup to the Settings page
…ettings

Move the Edit free listings page to a dedicated page and rename page to Shipping
Clean up the leftover parameters used to support WooCommerce Navigation
@eason9487 eason9487 added the changelog: none Skip changelog entry for this PR label Jan 9, 2025
@eason9487 eason9487 self-assigned this Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 19.51220% with 33 lines in your changes missing coverage. Please review.

Project coverage is 67.0%. Comparing base (90b564d) to head (6dd960b).
Report is 32 commits behind head on develop.

Files with missing lines Patch % Lines
src/Menu/Shipping.php 0.0% 14 Missing ⚠️
src/Menu/AttributeMapping.php 0.0% 4 Missing ⚠️
src/Menu/ProductFeed.php 0.0% 4 Missing ⚠️
src/Menu/Reports.php 0.0% 4 Missing ⚠️
src/Menu/Settings.php 0.0% 4 Missing ⚠️
js/src/index.js 50.0% 1 Missing ⚠️
...d/edit-program-button/edit-program-prompt-modal.js 0.0% 1 Missing ⚠️
...ernal/DependencyManagement/CoreServiceProvider.php 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             develop   #2757     +/-   ##
===========================================
- Coverage       67.0%   67.0%   -0.1%     
- Complexity      4690    4691      +1     
===========================================
  Files            479     796    +317     
  Lines          19601   24522   +4921     
  Branches           0    1204   +1204     
===========================================
+ Hits           13141   16423   +3282     
- Misses          6460    7962   +1502     
- Partials           0     137    +137     
Flag Coverage Δ
js-unit-tests 66.7% <80.0%> (?)
php-unit-tests 67.0% <0.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...listings/configure-product-listings/checkErrors.js 100.0% <100.0%> (ø)
js/src/components/main-tab-nav/main-tab-nav.js 90.0% <ø> (ø)
...c/pages/dashboard/all-programs-table-card/index.js 97.3% <100.0%> (ø)
js/src/pages/dashboard/index.js 83.3% <ø> (ø)
...s/src/pages/onboarding/setup-stepper/hero/index.js 100.0% <100.0%> (ø)
...es/onboarding/setup-stepper/saved-setup-stepper.js 87.2% <ø> (ø)
...c/pages/onboarding/setup-stepper/setup-listings.js 100.0% <100.0%> (ø)
js/src/pages/shipping/hasUnsavedShippingRates.js 100.0% <ø> (ø)
js/src/utils/urls.js 55.3% <100.0%> (ø)
js/src/index.js 75.7% <50.0%> (ø)
... and 7 more

... and 305 files with indirect coverage changes

…aving

Pop up confirmation prompt on the Shipping page before saving changes
@eason9487 eason9487 marked this pull request as ready for review January 13, 2025 06:57
@eason9487 eason9487 merged commit d7ad271 into develop Jan 13, 2025
16 checks passed
@eason9487 eason9487 deleted the feature/shipping-improvements branch January 13, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: none Skip changelog entry for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant