Clean up the leftover parameters used to support WooCommerce Navigation #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/shipping-improvements #2753 +/- ##
===============================================================
Coverage 66.9% 67.0%
Complexity 4691 4691
===============================================================
Files 796 796
Lines 24538 24522 -16
Branches 1204 1204
===============================================================
Hits 16423 16423
+ Misses 7978 7962 -16
Partials 137 137
Flags with carried forward coverage won't be shown. Click here to find out more.
|
puntope
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Thanks @eason9487 The Navigation still works as expected.
Screen.Recording.2025-01-07.at.21.20.25.mov
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Refer to #2406, it's no longer necessary to support WooCommerce Navigation feature, this PR cleans up the leftover parameters used to support the removed feature:
nav_argsparameter: https://github.com/woocommerce/woocommerce/pull/51559/files#diff-69a8b7c0a413b28dbe3e1b347b935a948d92c2dbbba5a7e8b0ef1018f54fbf49L62-L64navArgsparameter: https://github.com/woocommerce/woocommerce/pull/51559/files#diff-69a8b7c0a413b28dbe3e1b347b935a948d92c2dbbba5a7e8b0ef1018f54fbf49L117-L119(Noticed these leftover parameters while working on the shipping improvement project)
Detailed test instructions:
Check if all plugin menus are shown and pages can be visited as before.
Changelog entry