20241204-WOLF_AGG_DUMMY_MEMBER #8254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please. ( |
douzzer
force-pushed
the
20241204-WOLF_AGG_DUMMY_MEMBER
branch
2 times, most recently
from
c743847 to
cd89b42
Compare
bandi13
approved these changes
Dec 6, 2024
bandi13
suggested changes
Dec 6, 2024
…ble-fips=v5 set FIPS to 5.2.1; set DEF_FAST_MATH and DEF_SP_MATH to "no" when "yes" would conflict with user-supplied arguments.
…GG_DUMMY_MEMBER, pivoting on HAVE_EMPTY_AGGREGATES, and use WOLF_AGG_DUMMY_MEMBER in wc_Hashes.
… changed in d85c108 -- original value was correct, misdiagnosed by faulty test.
… for linuxv5.2.1, and add linuxv5-RC12.
…ak git fetching to keep wolfssl and fips tags distinct, and fetch all needed tags by name to assure availability for checkout. also, hide stdout noise from pushd/popd.
…_AGGREGATES to conform to wolfssl convention -- defined() for true, !defined() for false -- while retaining ability for user override-off by passing in explicit 0 definition.
…llness check around XFREE(ssl->buffers.digest.buffer, ...).
douzzer
force-pushed
the
20241204-WOLF_AGG_DUMMY_MEMBER
branch
from
cd89b42 to
0ad072a
Compare
bandi13
suggested changes
Dec 6, 2024
bandi13
approved these changes
Dec 6, 2024
kaleb-himes
approved these changes
Dec 6, 2024
|
note, partially addresses ZD#18760 for more on ZD#18760 see #8253 (WIP) |
JacobBarthelmeh
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wolfssl/wolfcrypt/types.handwolfssl/wolfcrypt/hash.h: defineWOLF_AGG_DUMMY_MEMBER, pivoting onHAVE_EMPTY_AGGREGATES, and useWOLF_AGG_DUMMY_MEMBERinwc_Hashes.configure.ac: add--enable-fips=cert4718alias forv5, and make--enable-fips=v5set FIPS to 5.2.1; setDEF_FAST_MATHandDEF_SP_MATHto "no" when "yes" would conflict with user-supplied arguments.