20241204-more-C89-expansion #8253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
previously requested changes
Dec 10, 2024
douzzer
force-pushed
the
20241204-more-C89-expansion
branch
2 times, most recently
from
f8dd844 to
e5c0373
Compare
douzzer
force-pushed
the
20241204-more-C89-expansion
branch
from
e5c0373 to
a557f44
Compare
|
retest this please ( |
…from -Warith-conversion -Wenum-conversion -Wfloat-conversion -Wsign-conversion.
douzzer
force-pushed
the
20241204-more-C89-expansion
branch
from
a557f44 to
122502e
Compare
dgarske
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wolfCrypt
-Wconversionexpansion: fix numerous warnings from-Warith-conversion -Wenum-conversion -Wfloat-conversion -Wsign-conversion.tested with
wolfssl-multi-test.sh ... super-quick-check '.*Wconversion.*'withand
(
CONVERSION_WARNINGSandFIPS_CONVERSION_WARNINGSare enhancements not yet pushed, that substitute for ad hoc-Wconversionin'.*Wconversion.*'scenarios.)