Delta update: check sha digest of base image #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only allow delta update if the sha digest of the base image matches the expected value. This is to prevent the delta update from being applied to an image that is not the expected base image, even if the version matches. The mismatch should never happen in real-life scenarios, but it is to check for false positives during integration, testing and development.
danielinux
force-pushed
the
delta-base-hash
branch
from
1edc78e to
adb0204
Compare
dgarske
requested changes
Nov 21, 2024
src/update_flash.c
Outdated
| return -1; | ||
| } | ||
| cur_v = wolfBoot_current_firmware_version(); | ||
| upd_v = wolfBoot_update_firmware_version(); | ||
| delta_base_v = wolfBoot_get_diffbase_version(PART_UPDATE); | ||
|
|
||
| if (delta_base_hash_sz != WOLFBOOT_SHA_DIGEST_SIZE) { | ||
| wolfBoot_printf("Delta update: Base hash size mismatch" |
There was a problem hiding this comment.
Should we have some type of backwards compatibility when the delta_base_v is not found? Delta update: Base hash size mismatch (size: 0 expected 20)
git checkout master
git distclean
make distclean
cp config/examples/sim-delta-update.config .config
make -C tools/keytools && make -C tools/bin-assemble
make clean && make test-sim-internal-flash-with-delta-update
git checkout delta-base-hash
make wolfboot.elf
./wolfboot.elf update_trigger get_version
./wolfboot.elf success get_version
There was a problem hiding this comment.
Done. Also added a (documented) option --no-base-sha for sign.
No SHA is not fatal now for wolfBoot.
Also added a test to prove that.
+ Added --no-base-sha option to sign
dgarske
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only allow delta update if the sha digest of the base image matches the expected value. This is to prevent the delta update from being applied to an image that is not the expected base image, even if the version matches.
The mismatch should never happen in real-life scenarios, but it is adviseable to check for false positives during integration, testing and development.