-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support wolfBoot on Renesas RZN2L #411
Conversation
62c90f5
to
048505e
Compare
@danielinux and @dgarske will review this wolfBoot port. PR cap, no action needed. |
-- update based on readme
fix spelling errors
6f8a08d
to
3683ad0
Compare
src/boot_renesas.c
Outdated
@@ -66,6 +66,10 @@ void do_boot(const uint32_t *app_offset) | |||
*/ | |||
app_entry = (void(*)(void))(*VECTOR_Reset_Handler); | |||
(*app_entry)(); | |||
#elif defined(_RENESAS_RZN_) | |||
app_entry = (void(*))(0x10010000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please avoid hard coding. This should come from .config or a linker script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I use an address value of linker script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Could you please add a short paragraph in docs/Targets.md
, so it's consistent with the other Renesas ports, and the target is properly tracked in the docs?
[edit] ideally the section in Targets.md
could also introduce the "verify/select candidate/load to ram" strategy required by the target, which is not obvious at first glance.
clean up
Hi @danielinux |
Looks good now, off to @dgarske for final comments & merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @miyazakh. Everything looks good. I will load this up in e2Studio as well and try to build them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference is full wolfBoot integration including startup code like I'm doing for PR #408, but I realize that is a lot more work. For now this is acceptable. Thank you
Initial Support wolfBoot on Renesas RZN2L