Initial support for LS1028A. Booting into OCRAM app. #306

billphipps · 2023-05-11T08:52:32Z

Still getting through some problems. Here's what's working:

Booting without TPM into OCRAM-based app. Used NO_XIP=1 to make wolfBoot copy into the load address
Booting with TPM sealing is working, except I haven't gotten the initial key into the TPM yet, so it fails to unseal and verify the signature. TPM access is working fine.
I updated spi_drv_nxp to gate on platform. There are some shenanigans that should be cleaner up as we stabilize the API.

Here's some hacks that I wasn't sure about:

Updated stack size usage test in options.mk because it checks for TPM first (limits to 6k) but with SP-math==0, we really need 7.5k. This needs a systemic update to handle max() of the options.
Ignored DTS stuff for now. Didn't seem to cause an issue.
With TPM enabled, there's a duplication of some functions with wolf crypt/misc.c. I added a guard on WOLFBOOT_TPM.
Skipped getting the DDR working for reals as we are targeting a simple OCRAM app for now.
Updated the wolfTPM submodule to the latest and greatest. This got sealing working.
I snuck the wolfBoot and app into the SPI NOR flash after the RCW and before the uBoot. Simply updated the start address in the RCW to point to wolf boot instead of uBoot. Can easily swap it back to get into uBoot and linux. Likely need this to preload the TPM key...

Here's the list of things that are broke

Measured boot now fails to compile. Likely a simple typo somewhere, but I didn't dig into it too far.
Test app is still likely still running at EL3. This must be pushed down.
MMU tables are likely not correct for anything past 512MB. Need to use the ones from CW
Documentation is still out of date. Prepping slides tomorrow (today) to add pictures of what we are doing and what we should/could do instead.
Still need to clean up the initial startup sequence and get it closer to the fully functions CW version.

Overall, pretty darn close and likely suitable for the customer demo. Glide path seems clear on the technical issues.

dgarske

Looks great! Just cleanups, but otherwise okay to merge.

dgarske · 2023-05-11T15:25:22Z

docs/Targets.md

@@ -13,6 +13,7 @@ This README describes configuration of supported targets.
 * [NXP P1021 PPC](#nxp-p1021-ppc)
 * [NXP T2080 PPC](#nxp-t2080-ppc)
 * [Qemu x86-64 UEFI](#qemu-x86-64-uefi)
+* [NXP LS1028A](#nxp-ls1028a)


Move up one line to sort with other NXP targets.

dgarske · 2023-05-11T15:25:42Z

hal/nxp_ls1028a.c

@@ -0,0 +1,1370 @@
+/* ls1028a.c
+ *
+ * Copyright (C) 2021 wolfSSL Inc.


dgarske · 2023-05-11T15:26:11Z

hal/nxp_ls1028a.c

+#define XSPI_MCR_LEARNEN_MASK       (0x1 << 15)    /* XSPI Learn Mode Enable */
+
+/* XSPI Init */
+/*#define XSPI_MCR0_CFG           0xFFFF80C0*/


Cleanup? Remove this or comment on why MCR0 has possible variation

dgarske · 2023-05-11T15:27:09Z

hal/nxp_ls1028a.c

+
+void erratum_err050568()
+{
+	/* Use IP bus only if systembus PLL is 300MHz (Dont use 300MHz) */


Do a replace of tab with 4 spaces please.

dgarske · 2023-05-11T15:27:23Z

hal/nxp_ls1028a.c

+}
+
+/* Application on Serial NOR Flash device 18.6.3 */
+void xspi_init()


void xspi_init(void)

dgarske · 2023-05-11T15:27:42Z

hal/nxp_ls1028a.c

+}
+
+/* Called from boot_aarch64_start.S */
+void hal_ddr_init() {


Function brace always on new line. Thanks

dgarske · 2023-05-11T15:28:41Z

options.mk

@@ -65,7 +65,8 @@ ifeq ($(SIGN),ECC256)
       STACK_USAGE=4096
  else
    ifeq ($(WOLFTPM),1)
-      STACK_USAGE=6680
+      ## Was 6680. Increasing to handle SPMATH=0
+      STACK_USAGE=7600


This is okay to increase or gate on the SPMATH the two options.

dgarske · 2023-05-11T15:30:13Z

src/boot_aarch64_start.S

@@ -99,3 +107,255 @@ gicv2_init_secure:
    str	 w0, [x1, #4]        /* GICC_PMR */
 1:
 	ret
+
+
+.global invalidate_ivac


This file is shared with a few other targets. Make sure any changes can be tolerated. zynqmp and raspi.

jpbland1 · 2023-05-11T16:55:12Z

config/examples/nxp-ls1028a.config

+DUALBANK_SWAP?=0
+PKA?=0
+
+WOLFTPM?=0


TPM and WOLFBOOT_TPM_KEYSTORE are disabled, why define the NV indicies if it's disabled?

This was a config that I was using without TPM support. Note compilation fails if ONLY WOLFBOOT_TPM is enabled without MEASURED_BOOT nor TPM_KEYSTORE, which was a suprise

jpbland1

IDE/Renesas/e2studio/RA6M4/app_RA/src/SEGGER_RTT/myprint.c empty file

jpbland1 · 2023-05-18T19:47:09Z

include/wolfboot/wolfboot.h

@@ -195,7 +195,11 @@ extern "C" {

 /* KeyStore API */
 int keystore_num_pubkeys(void);
+#if defined(WOLFBOOT_RENESAS_SCEPROTECT)


don't do this, just cast your buffer to uint32_t* in one place if you need it in that form

danielinux · 2024-07-22T10:59:15Z

@billphipps @dgarske is this still going or should I close as stale?

billphipps · 2024-07-22T12:35:03Z

I'll close it as stale. I think David pushed better versions of the shared files already.

dgarske · 2024-07-22T14:14:07Z

I believe this is still the latest LS1028A work and it is still on my list to work on. In fact I will likely be working on the Xilinx UltraScale+ and plan to pull this work in for that. Closing is fine for now

…This version was a refactor work in progress.

…rsion was a refactor work in progress.

billphipps requested review from danielinux and dgarske May 11, 2023 08:52

dgarske requested changes May 11, 2023

View reviewed changes

dgarske assigned billphipps May 11, 2023

billphipps requested a review from jpbland1 May 11, 2023 16:18

jpbland1 reviewed May 11, 2023

View reviewed changes

billphipps added 2 commits May 18, 2023 14:17

Initial support for LS1028A. Booting into OCRAM app.

71b782b

Update to add verbose unsealing during wolfboot

6f613df

jpbland1 requested changes May 18, 2023

View reviewed changes

jpbland1 reviewed May 18, 2023

View reviewed changes

billphipps added 2 commits May 22, 2023 09:57

Initial support for LS1028A. Booting into OCRAM app.

fc41632

Update to add verbose unsealing during wolfboot

b64ee37

billphipps force-pushed the ls1028ardb_support branch from 6e7186d to b64ee37 Compare May 22, 2023 14:01

dgarske mentioned this pull request Aug 10, 2023

Ls1028 #331

Closed

dgarske assigned dgarske and unassigned billphipps Nov 30, 2023

danielinux added the Later It won't be fixed in the upcoming release label Jul 22, 2024

billphipps closed this Jul 22, 2024

dgarske mentioned this pull request Nov 13, 2024

NXP LS1028ARDB #519

Merged

dgarske added a commit to dgarske/wolfBoot that referenced this pull request Nov 13, 2024

Reverted boot assembly back to changes from original PR wolfSSL#306. …

b7f0fea

…This version was a refactor work in progress.

danielinux pushed a commit that referenced this pull request Dec 2, 2024

Reverted boot assembly back to changes from original PR #306. This ve…

fea8610

…rsion was a refactor work in progress.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial support for LS1028A. Booting into OCRAM app. #306

Initial support for LS1028A. Booting into OCRAM app. #306

billphipps commented May 11, 2023

dgarske left a comment

dgarske May 11, 2023

dgarske May 11, 2023

dgarske May 11, 2023

dgarske May 11, 2023

dgarske May 11, 2023

dgarske May 11, 2023

dgarske May 11, 2023

dgarske May 11, 2023

jpbland1 May 11, 2023

billphipps May 11, 2023

jpbland1 left a comment

jpbland1 May 18, 2023

danielinux commented Jul 22, 2024

billphipps commented Jul 22, 2024

dgarske commented Jul 22, 2024

Initial support for LS1028A. Booting into OCRAM app. #306

Initial support for LS1028A. Booting into OCRAM app. #306

Conversation

billphipps commented May 11, 2023

dgarske left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jpbland1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danielinux commented Jul 22, 2024

billphipps commented Jul 22, 2024

dgarske commented Jul 22, 2024