Use 'python -m pip' instead of 'pip' for package installs.

[AGeekInside]

How would this feature be useful?
Using 'python -m pip' makes sure that the package installation is going into the expected python environment.

Describe the solution you'd like
Line 306 of sessions.py is where the install command runs 'pip'. I think a good solution would be to have the nox work simply run 'python -m pip' instead.

[theacodes]

Since Nox controls virtualenv creation, the path, and will error if the pip it finds isn't in the virtualenv's directory, is this necessary?

…

On Wed, Nov 6, 2019 at 12:22 PM Marc Brooks ***@***.***> wrote: *How would this feature be useful?* Using 'python -m pip' makes sure that the package installation is going into the expected python environment. *Describe the solution you'd like* Line 306 of sessions.py is where the install command runs 'pip'. I think a good solution would be to have the nox work simply run 'python -m pip' instead. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#262>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB5I4ZBCY3VQSFI6A7WJLTQSMRQ7ANCNFSM4JJ4NL2A> .

[AGeekInside]

Probably not necessary. I did make a fork to try out making the change, and it was easy enough, but it'll be purely cosmetic given the factors you pointed out.

I think the only argument to be made (weak as it is) is that it might be a good thing to adopt the best practice of 'python -m pip', but that doesn't seem like a huge benefit.

[theacodes]

Eh. I don't mind either way. If you wanna send a PR that does it that's fine with me.

…

On Wed, Nov 6, 2019 at 12:50 PM Marc Brooks ***@***.***> wrote: Probably not necessarily. I did make a fork to try out making the change, and it was easy enough, but it'll be purely cosmetic given the factors you pointed out. I think the only argument to be made (weak as it is) is that it might be a good thing to adopt the best practice of 'python -m pip', but that doesn't seem like a huge benefit. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#262>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB5I46UJA5FEUNF74ZOM6TQSMUYTANCNFSM4JJ4NL2A> .

[itsayellow]

This does have a concrete benefit. On Windows, pip install --upgrade pip will fail (because Windows won't allow pip to be uninstalled if its binary is being used) but python -m pip install --upgrade pip succeeds fine.

pipx recently had to switch its noxfile statement from

session.install("--upgrade", "pip")

to

session.run("python", "-m", "pip", "install", "--upgrade", "pip")

Because the original would crash if Windows actually needed to upgrade pip.
pypa/pipx#576