Fix tests on Windows by using python -m install --upgrade pip
#576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cs01
reviewed
Dec 1, 2020
| @@ -80,7 +80,7 @@ def on_master_no_changes(session): | |||
|
|
|||
| @nox.session(python=PYTHON_ALL_VERSIONS) | |||
| def tests(session): | |||
| session.install("--upgrade", "pip") | |||
| session.run("python", "-m", "pip", "install", "--upgrade", "pip") | |||
There was a problem hiding this comment.
Should we file an issue on the nox project to switch to this?
There was a problem hiding this comment.
Hmm maybe. It only is a problem for windows and pip.
I can file an issue.
There was a problem hiding this comment.
Looks like nox is about to merge a PR that does this very thing. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/changelog.mdSummary of changes
Somehow just now (?) Windows tests broke because we are using
pip install --upgrade pip. Windows can't upgrade an in-use pip which is open.Switched to the better form
python -m install --upgrade pip.Test plan
Tested by running