feat: form elements - text input documentation #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
catiarodriguescosta
commented
Jan 8, 2021
•
catiarodriguescosta
commented
- Moved component to a new page
- Added properties and examples for wmndsInput component
- Updated all references of input
- Updated input params
- Grouped params: error message params, label params, group params and attributes params (like Textarea)
- Error example
|
🚀 Deployed on https://deploy-preview-585--wmnetwork.netlify.app |
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
| }} | ||
| {% endif -%} | ||
| <input class="wmnds-fe-input{{errorClass}}{{paramClass}}" id="{{id}}" name="{{id}}" type="{{type}}"/> | ||
| <input |
There was a problem hiding this comment.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.
38 tasks
catiarodriguescosta
changed the base branch from
release
to
hb/feat/form-elements-docs
| }} | ||
| {% endif -%} | ||
| <input class="wmnds-fe-input{{errorClass}}{{paramClass}}" id="{{id}}" name="{{id}}" type="{{type}}"/> | ||
| <input |
There was a problem hiding this comment.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.
houbly
suggested changes
Jan 12, 2021
Co-authored-by: Houston Blyden <[email protected]>
Co-authored-by: Houston Blyden <[email protected]>
houbly
approved these changes
Jan 12, 2021
| @@ -36,7 +50,16 @@ | |||
| ) | |||
| }} | |||
| {% endif -%} | |||
| <input class="wmnds-fe-input{{errorClass}}{{paramClass}}" id="{{id}}" name="{{id}}" type="{{type}}"/> | |||
| <input | |||
There was a problem hiding this comment.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.
wmcadigital-admin
pushed a commit
that referenced
this pull request
Jan 20, 2021
# [1.2.0](v1.1.0...v1.2.0) (2021-01-20) ### Bug Fixes * Better formatting of HTML code snippets ([2442708](2442708)) * JS examples now work correctly. ([b3f7709](b3f7709)) * Nunjucks props appear better in table ([6ef138a](6ef138a)) * SCSS can now stream into the browser ([58a7f41](58a7f41)) * turned accessibility linting off as it is slowing down builds ([bdcccf7](bdcccf7)) * updated the copyright date ([#576](#576)) ([698a873](698a873)), closes [#567](#567) ### Features * Add entries for rail zone and app to A-Z content style guide ([#542](#542)) ([b1d69e6](b1d69e6)) * Adds new icons for cycle hire stations and e-bikes ([#547](#547)) ([1c68363](1c68363)), closes [#489](#489) [#489](#489) * Breadcrumbs documentation ([#551](#551)) ([bc65dbb](bc65dbb)) * buttons documentation ([#534](#534)) ([a80acbf](a80acbf)) * changes to content for deprecated components and patterns ([#541](#541)) ([3741c01](3741c01)) * content card documentation ([#553](#553)) ([13ad0fd](13ad0fd)) * details docs ([#535](#535)) ([e08cb09](e08cb09)) * display options for array type properties ([#548](#548)) ([6e14630](6e14630)) * Enhances metadata for Design System ([#546](#546)) ([20c3482](20c3482)) * file download documentation ([#539](#539)) ([0b449db](0b449db)) * form elements - checkbox documentation ([#580](#580)) ([5061996](5061996)) * form elements - date input documentation ([#588](#588)) ([19a4a1d](19a4a1d)) * form elements - dropdown documentation ([#583](#583)) ([17cf936](17cf936)) * Form elements - error message documentation ([#582](#582)) ([1ee82f0](1ee82f0)) * form elements - File upload documentation ([#587](#587)) ([61c0e24](61c0e24)) * form elements - form label documentation ([#571](#571)) ([f4380eb](f4380eb)) * form elements - progress indicator documentation ([#573](#573)) ([c01f434](c01f434)) * form elements - question documentation ([#572](#572)) ([9763203](9763203)) * form elements - radios documentation ([#584](#584)) ([03e1a31](03e1a31)) * form elements - text input documentation ([#585](#585)) ([640f68d](640f68d)) * form elements - textarea documentation ([#581](#581)) ([3122e64](3122e64)) * Improve imports of njk components ([#599](#599)) ([5ac01fe](5ac01fe)) * In-text step documentation ([#569](#569)) ([3853e1d](3853e1d)) * Inset text documentation ([#538](#538)) ([eae5a64](eae5a64)) * lists documentation ([#589](#589)) ([05bd895](05bd895)) * loader documentation ([#537](#537)) ([217c02f](217c02f)) * Markdown tags are now supported ([c4d460f](c4d460f)) * message documentation ([#554](#554)) ([adc7037](adc7037)) * phase indicator documentation ([#555](#555)) ([023d9cd](023d9cd)) * Updated homepage for the Design System ([#552](#552)) ([568eb49](568eb49)), closes [#543](#543) * Updated links docs ([#536](#536)) ([503c2ea](503c2ea)) * Warning text docs ([#545](#545)) ([444c341](444c341))
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.