Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: form elements - radios documentation #584

Merged
merged 12 commits into from
Jan 13, 2021

Conversation

houbly
Copy link
Contributor

@houbly houbly commented Jan 8, 2021

  • added properties and examples for wmndsRadios component
  • added and updated various param names to closer reflect GDS checkbox components
  • moved checkbox example to its own page

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

🚀 Deployed on https://deploy-preview-584--wmnetwork.netlify.app

@houbly houbly mentioned this pull request Jan 8, 2021
38 tasks
@houbly houbly changed the title feat: form elements - radio documentation feat: form elements - radios documentation Jan 8, 2021
Copy link
Contributor

@catiarodriguescosta catiarodriguescosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few notes to be discussed. 👍

Copy link
Contributor

@catiarodriguescosta catiarodriguescosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions! Didn't find anything else so far! 👍

Copy link
Contributor

@catiarodriguescosta catiarodriguescosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems good! I'll merge it! 👍

@catiarodriguescosta catiarodriguescosta merged commit 03e1a31 into hb/feat/form-elements-docs Jan 13, 2021
@catiarodriguescosta catiarodriguescosta deleted the hb/feat/radios-docs branch January 13, 2021 08:44
wmcadigital-admin pushed a commit that referenced this pull request Jan 20, 2021
# [1.2.0](v1.1.0...v1.2.0) (2021-01-20)

### Bug Fixes

* Better formatting of HTML code snippets ([2442708](2442708))
* JS examples now work correctly. ([b3f7709](b3f7709))
* Nunjucks props appear better in table ([6ef138a](6ef138a))
* SCSS can now stream into the browser ([58a7f41](58a7f41))
* turned accessibility linting off as it is slowing down builds ([bdcccf7](bdcccf7))
* updated the copyright date ([#576](#576)) ([698a873](698a873)), closes [#567](#567)

### Features

* Add entries for rail zone and app to A-Z content style guide ([#542](#542)) ([b1d69e6](b1d69e6))
* Adds new icons for cycle hire stations and e-bikes ([#547](#547)) ([1c68363](1c68363)), closes [#489](#489) [#489](#489)
* Breadcrumbs documentation ([#551](#551)) ([bc65dbb](bc65dbb))
* buttons documentation ([#534](#534)) ([a80acbf](a80acbf))
* changes to content for deprecated components and patterns ([#541](#541)) ([3741c01](3741c01))
* content card documentation ([#553](#553)) ([13ad0fd](13ad0fd))
* details docs ([#535](#535)) ([e08cb09](e08cb09))
* display options for array type properties ([#548](#548)) ([6e14630](6e14630))
* Enhances metadata for Design System ([#546](#546)) ([20c3482](20c3482))
* file download documentation ([#539](#539)) ([0b449db](0b449db))
* form elements - checkbox documentation ([#580](#580)) ([5061996](5061996))
* form elements - date input documentation ([#588](#588)) ([19a4a1d](19a4a1d))
* form elements - dropdown documentation ([#583](#583)) ([17cf936](17cf936))
* Form elements - error message documentation ([#582](#582)) ([1ee82f0](1ee82f0))
* form elements - File upload documentation ([#587](#587)) ([61c0e24](61c0e24))
* form elements - form label documentation ([#571](#571)) ([f4380eb](f4380eb))
* form elements - progress indicator documentation ([#573](#573)) ([c01f434](c01f434))
* form elements - question documentation ([#572](#572)) ([9763203](9763203))
* form elements - radios documentation ([#584](#584)) ([03e1a31](03e1a31))
* form elements - text input documentation ([#585](#585)) ([640f68d](640f68d))
* form elements - textarea documentation ([#581](#581)) ([3122e64](3122e64))
* Improve imports of njk components ([#599](#599)) ([5ac01fe](5ac01fe))
* In-text step documentation ([#569](#569)) ([3853e1d](3853e1d))
* Inset text documentation ([#538](#538)) ([eae5a64](eae5a64))
* lists documentation ([#589](#589)) ([05bd895](05bd895))
* loader documentation ([#537](#537)) ([217c02f](217c02f))
* Markdown tags are now supported ([c4d460f](c4d460f))
* message documentation ([#554](#554)) ([adc7037](adc7037))
* phase indicator documentation ([#555](#555)) ([023d9cd](023d9cd))
* Updated homepage for the Design System ([#552](#552)) ([568eb49](568eb49)), closes [#543](#543)
* Updated links docs ([#536](#536)) ([503c2ea](503c2ea))
* Warning text docs ([#545](#545)) ([444c341](444c341))
@wmcadigital-admin
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants