Remove our buffer clipping logic #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user should use wlr_scene_subsurface_tree_set_clip instead
ErikReider
added a commit
that referenced
this pull request
Nov 15, 2024
* Add wlr_scene blur impl * Added initial implementation of per output optimized blur * Added ability to only re-render optimized blur on a specific output * Fixed segfault if scene_buffer doesn't contain a scene_surface * Added support for wlr_scene_subsurface_tree_set_clip. Fixes blur not being clipped after #56 * Added optimized blur example to tinywl * Fixed blur opaque region not being correct for non scene_surfaces * Renamed wlr_scene_blur to wlr_scene_optimized_blur * Fixed optimized blur not being clipped * Renamed enum WLR_SCENE_NODE_BLUR -> WLR_SCENE_NODE_OPTIMIZED_BLUR * Fixed silly bug where setting num_passes to the default value wouldn't update * Translate toplevel opaque_region to compensate for GTK CSD * Set optimized blur node to always visible * Fixed not optimized blur being restricted to damage * Fixed blur corner rounding not matching scene_buffer * Renamed should_blur -> scene_buffer_is_blur_enabled * Simplified method of getting buffer opaque region * Don't always update the optimized blur when setting buffer blur state * Skip re-rendering optimized blur when the blur node is disabled * Fixed blur detection only working for wlr_scene_surface nodes * Use transformed output size when extending blur damage * Don't update the scene node twice when updating optimized size * TinyWL: skip commit on initial_commit Fixes setting size of border and shadow nodes too early, leading to the optimized blur example not working with GTK4 toplevels. * Rebase: wlroots 0.18.1 (#55) * updated flake for wlroots 0.18 * rebase: wlroots 0.18.1 (#55) * rebase fix * fix2 * Lowered version to 0.1 I'll let Will bump the version instead :) --------- Co-authored-by: William McKinnon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user should use wlr_scene_subsurface_tree_set_clip instead.
Causes some weird glitching when resizing GTK4 applications