Wlroots 0.18.1 #55
Wlroots 0.18.1 #55
Conversation
|
@WillPower3309 Should we also bump the scenefx version as well? (To make it easier for packagers and comp that use older versions of wlroots) |
Yup! Need to bump for the last wlroots bump then will merge this |
|
Tested it in ErikReider/fx-comp#9 and everything seems to be working as expected! :D |
|
i know this is well ahead of the curve, but trying on the latest wlroots 0.19 seems like removal of XDG clipping makes all the shadows and rounded corners wonky on gtk like the comment on it mentioned... did a bad job backporting on https://github.com/0xNULLderef/scenefx/tree/wlroots-0.19 for the sake of my own config but are there any plans to tackle this? i see the opaque region being defined but i have no idea how it relates to the actual rendered window contents tested apps are meld and waterfox (should be the same as firefox) that show a padding around the window and no rounded corners (tinywl from src tree) |
So we don't only officially support their main branch due to them not actually having a release of 0.19 yet, so we haven't checked for compatibility as of yet. So you'll kinda be on your own on this front until we port it to 0.19 in the coming months I read that they didn't remove the geometry, but moved it instead. Have you tried using that property?
This is due to client side decoration. The GTK toplevels have decorations like shadows and grabbing edges that affect the size of the toplevel if not compensated for, using it's geometry field :) |
|
needs rebase / merge from main |
* Add wlr_scene blur impl * Added initial implementation of per output optimized blur * Added ability to only re-render optimized blur on a specific output * Fixed segfault if scene_buffer doesn't contain a scene_surface * Added support for wlr_scene_subsurface_tree_set_clip. Fixes blur not being clipped after #56 * Added optimized blur example to tinywl * Fixed blur opaque region not being correct for non scene_surfaces * Renamed wlr_scene_blur to wlr_scene_optimized_blur * Fixed optimized blur not being clipped * Renamed enum WLR_SCENE_NODE_BLUR -> WLR_SCENE_NODE_OPTIMIZED_BLUR * Fixed silly bug where setting num_passes to the default value wouldn't update * Translate toplevel opaque_region to compensate for GTK CSD * Set optimized blur node to always visible * Fixed not optimized blur being restricted to damage * Fixed blur corner rounding not matching scene_buffer * Renamed should_blur -> scene_buffer_is_blur_enabled * Simplified method of getting buffer opaque region * Don't always update the optimized blur when setting buffer blur state * Skip re-rendering optimized blur when the blur node is disabled * Fixed blur detection only working for wlr_scene_surface nodes * Use transformed output size when extending blur damage * Don't update the scene node twice when updating optimized size * TinyWL: skip commit on initial_commit Fixes setting size of border and shadow nodes too early, leading to the optimized blur example not working with GTK4 toplevels. * Rebase: wlroots 0.18.1 (#55) * updated flake for wlroots 0.18 * rebase: wlroots 0.18.1 (#55) * rebase fix * fix2 * Lowered version to 0.1 I'll let Will bump the version instead :) --------- Co-authored-by: William McKinnon <[email protected]>
TinyWL runs. Can't really test Sway yet though.
Requires: #54
Working implementation:
ErikReider/fx-comp#9