Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch statics from github #196

Merged
merged 7 commits into from
May 18, 2022
Merged

Fetch statics from github #196

merged 7 commits into from
May 18, 2022

Conversation

Tommytrg
Copy link
Member

@Tommytrg Tommytrg commented May 10, 2022 •
edited
Loading

This PR supersedes #183

@Tommytrg Tommytrg force-pushed the fetch-static branch 7 times, most recently from c24882d to 2104729 Compare May 11, 2022 14:38
@Tommytrg Tommytrg force-pushed the fetch-static branch 3 times, most recently from 4ecab9e to 7489996 Compare May 11, 2022 15:44
@Tommytrg Tommytrg force-pushed the fetch-static branch 2 times, most recently from 89681bf to d28d604 Compare May 11, 2022 15:57
@Tommytrg Tommytrg marked this pull request as ready for review May 12, 2022 14:16
@Tommytrg Tommytrg requested a review from gabaldon May 12, 2022 14:16
gabaldon
gabaldon requested changes May 13, 2022
View reviewed changes
packages/api/src/fetchSvgs.ts Outdated Show resolved Hide resolved
packages/api/src/svgCache.ts Show resolved Hide resolved
@Tommytrg Tommytrg force-pushed the fetch-static branch 2 times, most recently from 8c5e2dd to 3d44ebc Compare May 13, 2022 11:31
@gabaldon gabaldon mentioned this pull request May 17, 2022
Closed
gabaldon
gabaldon reviewed May 18, 2022
View reviewed changes
packages/api/src/fetchSvgs.ts Outdated
'https://raw.githubusercontent.com/witnet/data-feeds-explorer/main/packages/ui/assets/svg/'

export async function fetchSvgs (
networksToFech: Array<string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
networksToFech: Array<string>
networksToFetch: Array<string>

@Tommytrg Tommytrg force-pushed the fetch-static branch 3 times, most recently from d3229d7 to 8a6421f Compare May 18, 2022 09:27
@Tommytrg Tommytrg merged commit 23dc554 into witnet:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabaldon gabaldon gabaldon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read configuration file from Github Retrieve logos from a static server
2 participants
@Tommytrg @gabaldon