Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve logos from a static server #153

Closed
gabaldon opened this issue Mar 14, 2022 · 2 comments · Fixed by #196
Closed

Retrieve logos from a static server #153

gabaldon opened this issue Mar 14, 2022 · 2 comments · Fixed by #196
Assignees
Labels
enhancement New feature or request

Comments

@gabaldon
Copy link
Collaborator

No description provided.

@gabaldon gabaldon added the enhancement New feature or request label Mar 14, 2022
@Tommytrg
Copy link
Member

To accomplish our goal of avoiding release a new version, every time we add or update a new price feed, we have to implement #153, but we also have to add images without releasing a new version. Currently, when we add a new price feed, we include the network and token SVGs in the release.

A workaround would be to upload the images to a static server and fetch the images from there. The easiest way to build this is setting up an Amazon S3, Azure Blob Storage, Google Cloud Storage or Firebase Storage

See also #154

@Tommytrg
Copy link
Member

Finally, we have decided to upload the different logos to the Github repository and read them from there

@Tommytrg Tommytrg changed the title Implement a static file server to retrieve logos Retrieve logos from a static server Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants