Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples index hero button action variants #2234

Merged
merged 2 commits into from
Aug 17, 2024

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Aug 17, 2024

Description

This PR updates the hero button action variants in the examples following the changes of #1784.

Copy link

changeset-bot bot commented Aug 17, 2024

⚠️ No Changeset found

Latest commit: c5eceee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Aug 17, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit c5eceee
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/66c089a78f6611000885541b
😎 Deploy Preview https://deploy-preview-2234--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, great call — ran into this myself last night making demos.

@HiDeoo HiDeoo merged commit 6b85ab5 into withastro:main Aug 17, 2024
14 checks passed
@HiDeoo HiDeoo deleted the hd-examples-index-hero-actions-variants branch August 17, 2024 11:31
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Aug 19, 2024
* main: (121 commits)
  i18n(zh-cn): Update components.mdx (withastro#2240)
  i18n(zh-cn): Update frontmatter.mdx (withastro#2239)
  i18n(zh-cn): Update pages.mdx (withastro#2238)
  i18n(zh-cn): Add synced tabs persistence (withastro#2236)
  Update examples index hero button action variants (withastro#2234)
  i18n(fr): update `guides/components` (withastro#2232)
  i18n(fr): update `guides/pages` (withastro#2224)
  [i18nIgnore] docs: update `index.mdx` hero action buttons variants (withastro#2233)
  i18n(fr): update `reference/frontmatter` (withastro#2223)
  i18n(fr): update `index` (withastro#2222)
  docs: add Cloudflare Docs to showcase (withastro#2221)
  i18n(ko-KR): update `pages.mdx` (withastro#2227)
  i18n(ko-KR): update `components.mdx` (withastro#2225)
  i18n(ko-KR): update `fontmatter.md` (withastro#2231)
  i18n(ko-KR): update `manual-setup.mdx` (withastro#2230)
  [ci] format
  i18n(ko-KR): update `index.mdx` (withastro#2229)
  i18n(ko-KR): update `site-search.mdx` (withastro#2228)
  i18n(ko-KR): update `customization.mdx` (withastro#2226)
  i18n(fr): add missing `syncKey` to various pages (withastro#2218)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants