Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(fr): update index #2222

Merged
merged 2 commits into from
Aug 17, 2024
Merged

i18n(fr): update index #2222

merged 2 commits into from
Aug 17, 2024

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Aug 16, 2024

Description

This PR updates the French version of the index page with the changes from #1784.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 286baf7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Aug 16, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 16, 2024 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 286baf7
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/66c081b0c1d240000873f5d6
😎 Deploy Preview https://deploy-preview-2222--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Aug 16, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
fr index.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

delucis
delucis approved these changes Aug 17, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, great point! I wonder if we should actually do a single i18nIgnore PR to update these in all languages?

But this PR LGTM 🙌

@delucis
Copy link
Member

delucis commented Aug 17, 2024

(Also, missed the PR number: #2222 🥳)

@HiDeoo
Copy link
Member Author

HiDeoo commented Aug 17, 2024

I wonder if we should actually do a single i18nIgnore PR to update these in all languages?

Good call, I'll make a PR after merging this one. I already merged ko earlier this morning and there is no other opened PRs for this file so might as well do it now 👍

@HiDeoo HiDeoo merged commit cf85c8b into withastro:main Aug 17, 2024
15 checks passed
@HiDeoo HiDeoo deleted the hd-i18n-fr-0-26-0-index branch August 17, 2024 10:58
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Aug 19, 2024
@HiDeoo
Merge branch 'main' into hd-feat-docs-components
ea2fa02 
* main: (121 commits)
  i18n(zh-cn): Update components.mdx (withastro#2240)
  i18n(zh-cn): Update frontmatter.mdx (withastro#2239)
  i18n(zh-cn): Update pages.mdx (withastro#2238)
  i18n(zh-cn): Add synced tabs persistence (withastro#2236)
  Update examples index hero button action variants (withastro#2234)
  i18n(fr): update `guides/components` (withastro#2232)
  i18n(fr): update `guides/pages` (withastro#2224)
  [i18nIgnore] docs: update `index.mdx` hero action buttons variants (withastro#2233)
  i18n(fr): update `reference/frontmatter` (withastro#2223)
  i18n(fr): update `index` (withastro#2222)
  docs: add Cloudflare Docs to showcase (withastro#2221)
  i18n(ko-KR): update `pages.mdx` (withastro#2227)
  i18n(ko-KR): update `components.mdx` (withastro#2225)
  i18n(ko-KR): update `fontmatter.md` (withastro#2231)
  i18n(ko-KR): update `manual-setup.mdx` (withastro#2230)
  [ci] format
  i18n(ko-KR): update `index.mdx` (withastro#2229)
  i18n(ko-KR): update `site-search.mdx` (withastro#2228)
  i18n(ko-KR): update `customization.mdx` (withastro#2226)
  i18n(fr): add missing `syncKey` to various pages (withastro#2218)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HiDeoo @astrobot-houston @delucis