Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add spacing to 'added in' texts #5765

Merged
merged 3 commits into from
Dec 13, 2023
Merged

fix: add spacing to 'added in' texts #5765

merged 3 commits into from
Dec 13, 2023

Conversation

kevinzunigacuellar
Copy link
Member

Description

Add spacing to <Since /> elements

Before After
image image

@vercel Vercel
Copy link

vercel bot commented Dec 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 13, 2023 6:14pm

@ElianCodes
Copy link
Member

ElianCodes commented Dec 13, 2023 •
edited
Loading

Wouldn't it make more sense to add padding to the <Since /> component instead of wrapping all of them in a <p />?

@ElianCodes ElianCodes self-requested a review December 13, 2023 08:53
@kevinzunigacuellar
Copy link
Member Author

Wouldn't it make more sense to add padding to the <Since /> component instead of wrapping all of them in a <p />?

It would but there are some instances of Since that are inlined 😅

@ElianCodes
Copy link
Member

in that case, what about a prop for spacing, that defaults to none?

delucis
delucis approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for tackling this @kevinzunigacuellar 💜

@sarah11918 sarah11918 added site improvement Some thing that improves the website functionality - ask @delucis for help! Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Dec 13, 2023
@sarah11918
Copy link
Member

Thanks, Kevin! I updated Astro Docs Docs to show this usage of the component in a standalone line!

@delucis delucis merged commit 2d7a9d2 into main Dec 13, 2023
6 checks passed
@delucis delucis deleted the add-p branch December 13, 2023 18:14
This was referenced Dec 20, 2023
Merged
Merged
Merged
@morinokami morinokami mentioned this pull request Dec 24, 2023
Merged
This was referenced Dec 24, 2023
Merged
Merged
This was referenced Jan 2, 2024
Merged
Merged
Merged
Merged
Merged
yanthomasdev added a commit that referenced this pull request Jan 4, 2024
@McFlyPartages @yanthomasdev
i18n(fr) Update rss.mdx (#6096)
f77ae0f 
Update french translation for rss.mdx file with PR #5765

Co-authored-by: Yan Thomas <[email protected]>
@liruifengv liruifengv mentioned this pull request Jan 8, 2024
Merged
@McFlyPartages McFlyPartages mentioned this pull request Jan 13, 2024
Merged
dreyfus92 added a commit that referenced this pull request Jan 14, 2024
@McFlyPartages @dreyfus92
i18n(fr) Update some file with pr#6267 and big update `cli-reference.…
6e429cf 
…mdx` (#6363)

* i18n(fr) Update reading-time.mdx

Just for translator tracker because the PR #5766 should have been [ignore]

* Update astro-pages.mdx

* Update framework-components.mdx

* Update layouts.mdx

* Update routing.mdx

* Update editor-setup.mdx

* Update configuring-astro.mdx

* Update cloudflare.mdx

* Update deno.mdx

* Update netlify.mdx

* Update vercel.mdx

* Update imports.mdx

* Update auto.mdx

* Update manual.mdx

* Update cli-reference.mdx

Update and del some parts

* Update cli-reference.mdx

Update fiule with PR #5512 #5651 #5604 #5765 #6040 #6043 #6109 #6267

* Update auto.mdx

* Update cloudflare.mdx

fix PR #5284

* Update markdown-content.mdx

* Update auto.mdx

* Update src/content/docs/fr/core-concepts/astro-pages.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/core-concepts/astro-pages.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/core-concepts/astro-pages.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/core-concepts/framework-components.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/core-concepts/framework-components.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/guides/markdown-content.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/install/manual.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/install/manual.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/reference/cli-reference.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Apply suggestions from code review

---------

Co-authored-by: Paul Valladares <[email protected]>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
@kevinzunigacuellar @sarah11918
@delucis @ElianCodes @ematipico
fix: add spacing to 'added in' texts (#5765)
9b8f737 
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Elian <[email protected]>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
@McFlyPartages @yanthomasdev @ematipico
i18n(fr) Update rss.mdx (#6096)
1a408bd 
Update french translation for rss.mdx file with PR #5765

Co-authored-by: Yan Thomas <[email protected]>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
@McFlyPartages @dreyfus92 @ematipico
i18n(fr) Update some file with pr#6267 and big update `cli-reference.…
8015ac7 
…mdx` (#6363)

* i18n(fr) Update reading-time.mdx

Just for translator tracker because the PR #5766 should have been [ignore]

* Update astro-pages.mdx

* Update framework-components.mdx

* Update layouts.mdx

* Update routing.mdx

* Update editor-setup.mdx

* Update configuring-astro.mdx

* Update cloudflare.mdx

* Update deno.mdx

* Update netlify.mdx

* Update vercel.mdx

* Update imports.mdx

* Update auto.mdx

* Update manual.mdx

* Update cli-reference.mdx

Update and del some parts

* Update cli-reference.mdx

Update fiule with PR #5512 #5651 #5604 #5765 #6040 #6043 #6109 #6267

* Update auto.mdx

* Update cloudflare.mdx

fix PR #5284

* Update markdown-content.mdx

* Update auto.mdx

* Update src/content/docs/fr/core-concepts/astro-pages.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/core-concepts/astro-pages.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/core-concepts/astro-pages.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/core-concepts/framework-components.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/core-concepts/framework-components.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/guides/markdown-content.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/install/manual.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/install/manual.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/reference/cli-reference.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Apply suggestions from code review

---------

Co-authored-by: Paul Valladares <[email protected]>
@morinokami morinokami mentioned this pull request Feb 24, 2024
Merged
@morinokami morinokami mentioned this pull request Mar 3, 2024
Merged
fhiromasa added a commit to fhiromasa/astro-docs that referenced this pull request Mar 3, 2024
@fhiromasa
update routing.mdx in ja
0e36aea 
fix: add spacing to 'added in' texts (withastro#5765)
yanthomasdev added a commit that referenced this pull request Mar 5, 2024
@fhiromasa @morinokami @yanthomasdev
i18n(ja): Update routing.mdx in ja (#7101)
5e59ee9 
* Update routing.mdx in ja

Modified to be similar to the English sample code in "Nested Pagination" section

* update routing.mdx in ja

[code-example-syntax] hippo-proof code examples (#5364)

* update routing.mdx in ja

fix: add spacing to 'added in' texts (#5765)

* update routing.mdx in ja

Add <ReadMore> component (#6267)

* Update routing.mdx in ja

Document new routing priority behavior (#6386)

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <[email protected]>

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <[email protected]>

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <[email protected]>

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <[email protected]>

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <[email protected]>

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <[email protected]>

---------

Co-authored-by: Shinya Fujino <[email protected]>
Co-authored-by: Yan <[email protected]>
trueberryless added a commit to trueberryless/withastro-docs that referenced this pull request Oct 22, 2024
@trueberryless
update translation withastro#5765
1144db6
@trueberryless trueberryless mentioned this pull request Oct 22, 2024
Merged
yanthomasdev added a commit that referenced this pull request Nov 4, 2024
@trueberryless @Maxframe @yanthomasdev
i18n(de): update basics/astro-pages.mdx (#9759)
c478fe4 
* update translation #1442

* update translation #1434

* update translation #1510

* update translation #1538

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* update translation #1638

* update translation #2091

* update translation #2133

* update translation #2409

* update translation #2371

* update translation #4610

* update translation #5128

* update translation #5205

* update translation #5240

* update translation #5364

* update translation #5765

* update translation #6267

* remove paragraph where I cant find when it was deleted in original version

* update translation #6620

* update translation #8495

* update translation #8573

* update translation #9336

* update translation #9336 2/2

didnt save file locally, so git didnt add

* fix all visual differences by comparing manually against original english version

* fix broken links in `astro-pages.mdx`

* Breaking changes to other files! fixing links which link to the �stro-pages.mdx file

* but now...

* Update src/content/docs/de/basics/astro-pages.mdx

Co-authored-by: Max <[email protected]>

* Update src/content/docs/de/basics/astro-pages.mdx

Co-authored-by: Max <[email protected]>

* Update src/content/docs/de/basics/astro-pages.mdx

Co-authored-by: Max <[email protected]>

* revert Update markdown-content.mdx

@lunaria-track:src/content/docs/de/basics/astro-pages.mdx

---------

Co-authored-by: Max <[email protected]>
Co-authored-by: Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

@ElianCodes ElianCodes Awaiting requested review from ElianCodes

Assignees
No one assigned
Labels
Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! site improvement Some thing that improves the website functionality - ask @delucis for help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinzunigacuellar @ElianCodes @sarah11918 @delucis