Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I18n(ja) update images.mdx #5840

Merged
merged 14 commits into from
Dec 24, 2023
Merged

I18n(ja) update images.mdx #5840

merged 14 commits into from
Dec 24, 2023

Conversation

yusasa16
Copy link
Contributor

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@vercel Vercel
Copy link

vercel bot commented Dec 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 24, 2023 0:36am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Dec 24, 2023 0:36am

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Dec 19, 2023
@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@morinokami
Copy link
Contributor

@yusasa16 Thank you for the update! I have one question: according to the source change history, there are more changes than just b91953c. Do you plan to handle these in this PR?

@yusasa16
Copy link
Contributor Author

@morinokami Thank you for reviewing!
I wasn't aware of those changes, so i didn't plan that.
Should I include those changes in this PR?
If it is better, I can add commits :)

@sarah11918
Copy link
Member

Hi @yusasa16 ! Yes, if you are able to make those changes here, that would be very helpful!

It's still OK if you don't, so you can choose and tell me your decision!

@sarah11918
Copy link
Member

There has been one more PR made! 😄

Line 628 can also be updated here, according to this PR #5857

@yusasa16
Copy link
Contributor Author

@sarah11918 Okay! I'll do that👍
I will submit again on this weekend.
There is one question. Should I convert to draft this PR?
Actually, this is the first time to send PR to Open Source Project, so I want to know manner.

@sarah11918
Copy link
Member

Hi @yusasa16 ! Yes, you can choose to convert to draft so that the other Japanese translators know that it is not completely ready for review! (It is not required, but it can be a good way to communicate to others what the status is.)

I am very happy this is your first contribution to open-source! Thank you for choosing to help us! 🙌

@yusasa16 yusasa16 marked this pull request as draft December 21, 2023 15:55
@yusasa16
Copy link
Contributor Author

@sarah11918 Thanks! I've just converted.
After completing, I'll make this PR back status to open👍

@yusasa16 yusasa16 marked this pull request as ready for review December 23, 2023 16:40
@yusasa16
Copy link
Contributor Author

@morinokami @sarah11918
It’s completed! Could you review again?

morinokami
morinokami reviewed Dec 24, 2023
View reviewed changes
Copy link
Contributor

@morinokami morinokami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yusasa16 色々と変更が積み重なっており大変だったと思いますが、全体的に上手く訳せていると思いました！ありがとうございます🙏

いくつか主に細かい点について Suggestions を残したので、問題なければ取り込んでいただき、終わったら再度自分に Assign をお願いします。

src/content/docs/ja/guides/images.mdx Outdated Show resolved Hide resolved
src/content/docs/ja/guides/images.mdx Outdated Show resolved Hide resolved
src/content/docs/ja/guides/images.mdx Outdated Show resolved Hide resolved
src/content/docs/ja/guides/images.mdx Outdated Show resolved Hide resolved
src/content/docs/ja/guides/images.mdx Outdated Show resolved Hide resolved
src/content/docs/ja/guides/images.mdx Outdated Show resolved Hide resolved
src/content/docs/ja/guides/images.mdx Outdated Show resolved Hide resolved
src/content/docs/ja/guides/images.mdx Outdated Show resolved Hide resolved
@yusasa16 yusasa16 requested a review from morinokami December 24, 2023 08:03
@yusasa16
Copy link
Contributor Author

@morinokami 細かく見ていただきありがとうございます！
今回追加いただいたSuggestionsについては、全て確認して取り込ませていただきました🙇

morinokami
morinokami approved these changes Dec 24, 2023
View reviewed changes
Copy link
Contributor

@morinokami morinokami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応ありがとうございました、LGTM!!

yanthomasdev
yanthomasdev approved these changes Dec 24, 2023
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work peeps! And welcome to Team Docs @yusasa16 🙌

@yanthomasdev yanthomasdev merged commit 77b7a66 into withastro:main Dec 24, 2023
8 checks passed
ematipico pushed a commit that referenced this pull request Jan 26, 2024
@yusasa16 @yanthomasdev
@sarah11918 @morinokami @ematipico
i18n(ja): update images.mdx (#5840)
72d9944 
* i18n(ja): Update /guides/images.mdx

* i18n(ja): Update /guides/images.mdx

translate

* i18n(ja): Update /guides/images.mdx

* Update src/content/docs/ja/guides/images.mdx

Co-authored-by: Shinya Fujino <[email protected]>

* Update src/content/docs/ja/guides/images.mdx

Co-authored-by: Shinya Fujino <[email protected]>

* Update src/content/docs/ja/guides/images.mdx

Co-authored-by: Shinya Fujino <[email protected]>

* Update src/content/docs/ja/guides/images.mdx

Co-authored-by: Shinya Fujino <[email protected]>

* Update src/content/docs/ja/guides/images.mdx

Co-authored-by: Shinya Fujino <[email protected]>

* Update src/content/docs/ja/guides/images.mdx

Co-authored-by: Shinya Fujino <[email protected]>

* Update src/content/docs/ja/guides/images.mdx

Co-authored-by: Shinya Fujino <[email protected]>

* Update src/content/docs/ja/guides/images.mdx

Co-authored-by: Shinya Fujino <[email protected]>

---------

Co-authored-by: Yan Thomas <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Shinya Fujino <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanthomasdev yanthomasdev yanthomasdev approved these changes

@morinokami morinokami morinokami approved these changes

Assignees
No one assigned
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yusasa16 @astrobot-houston @morinokami @sarah11918 @yanthomasdev