Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(routing): trailingSlash on endpoints #9597

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Jan 3, 2024

Changes

Testing

Added a unit test.
image

Docs

Does not affect behavior.

Copy link

changeset-bot bot commented Jan 3, 2024

🦋 Changeset detected

Latest commit: e0374e8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Jan 3, 2024
@lilnasy lilnasy marked this pull request as ready for review January 3, 2024 20:14
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally 🙏

@ematipico ematipico merged commit 9fd24a5 into withastro:main Jan 4, 2024
4 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jan 4, 2024
@lilnasy lilnasy deleted the fix/9206 branch January 5, 2024 15:18
@kripod
Copy link

kripod commented Feb 17, 2024

Thanks for enforcing this.

Unfortunately, the change breaks Static File Endpoints in development as I reported here: #10149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Route always returns 404 on Vercel depending on trailingSlash
4 participants