Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking(typed api): support for trailingSlash #59

Merged
merged 4 commits into from
Jan 5, 2024
Merged

breaking(typed api): support for trailingSlash #59

merged 4 commits into from
Jan 5, 2024

Conversation

lilnasy
Copy link
Owner

@lilnasy lilnasy commented Jan 5, 2024

Changes

  • Since Astro 4.1, API endpoints now require a trailing slash if configured by the user.
  • fix(routing): trailingSlash on endpoints withastro/astro#9597
  • If trailingSlash is configured, the previous version of typed-api will no longer work.
  • The next version of typed-api will no longer work on astro 4.0 or lower.

Tests

  • Existing tests should pass. (base and trailingSlash are already tested)

Docs

  • peerDependencies range will be updated to require astro 4.1+.
  • Does not affect usage.

Copy link

changeset-bot bot commented Jan 5, 2024

🦋 Changeset detected

Latest commit: 0f98bda

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lilnasy lilnasy merged commit 9cd7f72 into main Jan 5, 2024
6 checks passed
@lilnasy lilnasy deleted the update branch January 5, 2024 15:24
@github-actions github-actions bot mentioned this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant