Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix history navigation to hash fragment on Firefox when using view transitions #9563

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Fix history navigation to hash fragment on Firefox when using view transitions #9563

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11e5b52
Fix history navigation to hash fragment on Firefox when using view tr…
martrapp Jan 1, 2024
beb008c
Edit changeset
martrapp Jan 1, 2024
5aee87b
Improve changeset, add co-authors
martrapp Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/breezy-eyes-teach.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"astro": patch
---

Fix history navigation to hash fragment on Firefox when using view transitions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Fix history navigation to hash fragment on Firefox when using view transitions
Fixes history navigation to hash fragment on Firefox when using View Transitions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were deliberately using the imperative form?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the opposite 🤔 we need Sarah (on phone rn, I can't ping for some reason)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarah11918 to the rescue!

martrapp marked this conversation as resolved.
Show resolved Hide resolved
4 changes: 3 additions & 1 deletion packages/astro/src/transitions/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,9 @@ const moveToLocation = (to: URL, from: URL, options: Options, historyState?: Sta
// ... what comes next is a intra-page navigation
// that won't reload the page but instead scroll to the fragment
history.scrollRestoration = 'auto';
location.href = to.href;
const savedState = history.state;
martrapp marked this conversation as resolved.
Show resolved Hide resolved
location.href = to.href; // this kills the history state on Firefox
history.replaceState(savedState, ''); // this restores the history state
} else {
if (!scrolledToTop) {
scrollTo({ left: 0, top: 0, behavior: 'instant' });
Expand Down
Loading