Fix history navigation to hash fragment on Firefox when using view transitions #9563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5aee87b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
.changeset/breezy-eyes-teach.md
Outdated
| "astro": patch | ||
| --- | ||
|
|
||
| Fix history navigation to hash fragment on Firefox when using view transitions |
There was a problem hiding this comment.
Suggested change
| Fix history navigation to hash fragment on Firefox when using view transitions | |
| Fixes history navigation to hash fragment on Firefox when using View Transitions |
There was a problem hiding this comment.
I thought we were deliberately using the imperative form?
There was a problem hiding this comment.
I thought the opposite 🤔 we need Sarah (on phone rn, I can't ping for some reason)
There was a problem hiding this comment.
@sarah11918 to the rescue!
bluwy
approved these changes
Jan 2, 2024
matthewp
approved these changes
Jan 2, 2024
sarah11918
reviewed
Jan 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Firefox clears the history state on same page navigation, which later breaks history navigation.
This fix prevents that.
From discord user mcoms on #support > View Transitions back/forward not working in Firefox for fragment links:
SvelteKit had a similar issue.
Their analysis put me on the right track.
Testing
Tested manually on Firefox as we do not run automated e2e tests on Firefox.
Docs
n/a bug fix.