Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getViteConfig return type #6753

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Fix getViteConfig return type #6753

merged 1 commit into from
Apr 5, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Apr 5, 2023

Changes

Fix #6750

getViteConfig returns a Vite config function, not the Vite config

Testing

Manually tested the with-vitest example which uses this API, and it still works.

Docs

n/a. it doesn't look like getViteConfig is documented currently.

@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2023

🦋 Changeset detected

Latest commit: abf809b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Apr 5, 2023
@matthewp matthewp merged commit 489dd8d into main Apr 5, 2023
@matthewp matthewp deleted the fix-get-vite-config-types branch April 5, 2023 13:06
@astrobot-houston astrobot-houston mentioned this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: getViteConfig return type error
3 participants