Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: getViteConfig return type error #6750

Closed
1 task
NWYLZW opened this issue Apr 4, 2023 · 1 comment · Fixed by #6753
Closed
1 task

Bug: getViteConfig return type error #6750

NWYLZW opened this issue Apr 4, 2023 · 1 comment · Fixed by #6753
Labels
- P3: minor bug An edge case that only affects very specific usage (priority)

Comments

@NWYLZW
Copy link

NWYLZW commented Apr 4, 2023

What version of astro are you using?

2.1.9

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

yarn

What operating system are you using?

Mac

What browser are you using?

Chrome

Describe the Bug

getViteConfig api export type is interface
image

image

but

astro/packages/astro/src/config/index.ts

Line 11 in 4cc1bf6

return async ({ mode, command }: { mode: string; command: 'serve' | 'build' }) => {

it is async function

Link to Minimal Reproducible Example

none

Participation

  • I am willing to submit a pull request for this issue.
@bluwy bluwy mentioned this issue Apr 5, 2023
Merged
@bluwy bluwy added the - P3: minor bug An edge case that only affects very specific usage (priority) label Apr 5, 2023
@fardarter
Copy link

The docs need to be updated with correct usage please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
- P3: minor bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix getViteConfig return type withastro/astro
3 participants
@fardarter @bluwy @NWYLZW