Prevent astro:content from depending on Node builtins #6537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c255e86 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
natemoo-re
approved these changes
Mar 13, 2023
Comment on lines
231
to
238
| generateBundle() { | ||
| const nodeModules = ['node:fs', 'node:url', 'node:worker_threads', 'node:path']; | ||
| nodeModules.forEach(name => { | ||
| const mod = this.getModuleInfo(name); | ||
| if(mod) { | ||
| throw new Error(`Node builtins snuck in: ${name}`) | ||
| } | ||
| }); |
There was a problem hiding this comment.
This is very smart! I wonder if this would be useful as a more general (not CC-specific) test as well?
There was a problem hiding this comment.
Totally. I remember multiple breaking bugs with the Markdown plugin a while back too
There was a problem hiding this comment.
Yeah, I can move this into test-utils so other tests can use it more easily
There was a problem hiding this comment.
Created a test-plugins.js file so we can put more stuff like this if needed.
1 task
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
--experimental-assetshas.Testing
Docs
N/A, bug fix