[Beta] Astro MDX renderer is not bundled

[universse]

Astro Info

Astro                    v5.0.0-beta.1
Node                     v22.6.0
System                   Windows (x64)
Package Manager          pnpm
Output                   static
Adapter                  @astrojs/cloudflare
Integrations             @astrojs/react
                         @astrojs/mdx
                         @astrojs/sitemap

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

Deployment to CF Pages failed due to non-existent '@astrojs/mdx/server.js'.

Here's the output of dist\_worker.js\chunks\_@astro-renderers_[hash].mjs.

globalThis.process ??= {}; globalThis.process.env ??= {};
import { p as getDefaultExportFromCjs } from './astro/server_CH__8xxn.mjs';
import _renderer1 from '@astrojs/mdx/server.js'; // <--- here

const opts = {
  experimentalReactChildren: false
};

var react = {exports: {}};
...

What's the expected result?

MDX renderer should be bundled.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-jkjbbg

Participation

• I am willing to submit a pull request for this issue.

[bluwy]

I can't reproduce the issue with the link given. I'm seeing that it's properly bundled. Perhaps you could double check that all Astro dependencies are upgraded?

[universse]

I've figured out the issue. I'm using Astro Container API. To make it work on Cloudflare, I previously needed to mark container modules as external and this does not work for Astro v5 beta.

  vite: {
    ssr: {
      // previously v4
      // external: ["astro/container", "@astrojs/mdx"],
      external: [
        'astro/container',
        'node:fs',
        'node:fs/promises',
        'fs',
        'node:url',
        'node:path',
        'path',
      ],
    },
  },

Here's the updated reproduction https://stackblitz.com/edit/github-jkjbbg-nhzsfm

Perhaps it's an issue with Astro Container API? Think it should work out of the box with CF integration.

[ematipico]

In order to fix the issue, you need to load the render manually, otherwise it isn't bundled. The way you're loading the renderer is meant for cases like vitest. This is mentioned in the docs:

When using vite (vitest, Astro integrations, etc.), the renderers are loaded with the function loadRenderers() from the virtual module astro:container. Outside vite, you’ll have to load the renderers manually.

Here's how you load the MDX renderers:

import mdxRenderer from "@astrojs/mdx/server.js";

const astroContainer = await AstroContainer.create();
astroContainer.addServerRenderer({renderer: mdxRenderer});

[universse]

Not sure I understand correctly. The reason I'm loading it as such is because of Node.js built-in imports causing Vite to throw error when building for Cloudflare workers (via @astrojs/cloudflare integration). Loading the renderers manually does not help.

[ematipico]

Not sure I understand correctly. The reason I'm loading it as such is because of Node.js built-in imports causing Vite to throw error when building for Cloudflare workers (via @astrojs/cloudflare integration). Loading the renderers manually does not help.

I did test it using your reproduction, and it built successfully.

[universse]

Yes, it built successfully because I added all Node.js built-ins to vite.external.ssr to Astro config. If you comment those out, the build will fail because Astro Container feature depends on Node built-ins. The page using the Astro Container is /blog/[...slug].

What I'm saying is Astro Container API should work with CF integration without having to configure vite.external.ssr. Having vite.external.ssr works fine for prerendered pages but not for server rendered pages that use the Container API.

Issue is somewhat similar to this #6537