Graceful error recovery in the dev server #5198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 278bb7a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
!preview hmr-recovery |
|
|
@matthewp No more fixture tests? That's amazing, very excited to give this a thorough review when I can! |
natemoo-re
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Looks awesome!
Very curious about the test structure here. I suppose packages/astro/test/units/** is the path of least resistance, but would it make more sense to have unit tests next to the files they are testing? Maybe that's something we can follow-up with.
Edit: Realized this is still a draft, dismissing my approval. Happy to circle back when this is ready!
|
!preview hmr-recovery |
|
matthewp
force-pushed
the
server-refactor
branch
4 times, most recently
from
49a3f00 to
cd30ef7
Compare
matthewp
commented
Oct 28, 2022
| /** | ||
| * The MIT License (MIT) | ||
| * Copyright (c) 2018 Andy Wermke | ||
| * https://github.com/andywer/typed-emitter/blob/9a139b6fa0ec6b0db6141b5b756b784e4f7ef4e4/LICENSE |
There was a problem hiding this comment.
Note that I brought this package internally because when Vite crawls through package.jsons, this one has a main but the main doesn't export anything so Vite warns about it not being a real ESM module. This is only a (small) types package, so brought it in.
bluwy
approved these changes
Oct 28, 2022
natemoo-re
approved these changes
Oct 31, 2022
tony-sull
approved these changes
Oct 31, 2022
| meta?: Record<string, any>; | ||
| } | ||
|
|
||
| export function createLoader(overrides: Partial<ModuleLoader>): ModuleLoader { |
There was a problem hiding this comment.
Very nice, I really like how the loader interface cleaned up the code flow here 👍
Move dev-container to dev Update for the lockfile Invalidate modules in an error state Test invalidation of broken modules Remove unused error state Normalize for windows try a larger timeout Fixes build just for testing more testing Keep it posix fully posix
matthewp
force-pushed
the
server-refactor
branch
from
b62e062 to
278bb7a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issues affected
Testing
core/dev, which is meant to encompass all of what dev does. This essentially makes the dev server unit-testable without needing to start the actual dev server and send HTTP requests. You can also define .astro (or other modules) in a virtual filesystem, so no more fixture tests.Docs
N/A