Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HMR: SolidJS Importing a module before creating it does not refresh after fixing #5158

Closed
1 task done
matthewp opened this issue Oct 21, 2022 · 0 comments · Fixed by #5198
Closed
1 task done

HMR: SolidJS Importing a module before creating it does not refresh after fixing #5158

matthewp opened this issue Oct 21, 2022 · 0 comments · Fixed by #5198
Assignees
@matthewp
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority) feat: hmr Related to HMR (scope)

Comments

@matthewp
Copy link
Contributor

What version of astro are you using?

1.5.2

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

npm

What operating system are you using?

Mac

Describe the Bug

  1. Use the Solid adapter
  2. Add an import to a module that does not exist
  3. Create that module
  4. The browser does not refresh.

Link to Minimal Reproducible Example

n/a

Participation

  • I am willing to submit a pull request for this issue.
@matthewp matthewp added - P4: important Violate documented behavior or significantly impacts performance (priority) feat: hmr Related to HMR (scope) labels Oct 21, 2022
@matthewp matthewp self-assigned this Oct 21, 2022
@matthewp matthewp mentioned this issue Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewp matthewp

Labels
- P4: important Violate documented behavior or significantly impacts performance (priority) feat: hmr Related to HMR (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Graceful error recovery in the dev server withastro/astro
1 participant
@matthewp