Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitpod - fix pnpm version error #4120

Merged
merged 6 commits into from
Aug 2, 2022

Conversation

shaal
Copy link
Contributor

@shaal shaal commented Aug 2, 2022

Changes

Testing

Note

  • After running pnpm run build, there are 2 minor changes in packages/webapi/mod.d.ts, I think these changes are not related to this PR, but probably should be committed to the repo.

Docs

This PR does not change anything in Astro itself, so no documentation update is needed.

@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2022

⚠️ No Changeset found

Latest commit: c96ed49

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you—this is wonderful! Test failures are unrelated.

Re: the webapi changes, we've seen that inconsistently across all PRs. Need to investigate that separately, it looks like a formatting only change introduced by different TypeScript versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants