Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to [email protected], remove patch-package #3747

Merged
merged 4 commits into from
Jul 7, 2022

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Jun 28, 2022

Changes

  • Upgrades to [email protected]
  • Removes patch-package dependency and postinstall script, pnpm has built-in support for pnpm patch now.
  • Patches @changesets/cli to ignore our private @example/*, @test/*, @e2e/*, and astro-scripts packages
    • This is a super common mistake first-time contributors make and changesets doesn't offer a native way to exclude these. Patching seems better than the confusing experience we have now

Before
CleanShot 2022-06-28 at 12 32 23@2x

After
CleanShot 2022-06-28 at 12 31 50@2x

Testing

N/A, internal change only

Docs

N/A, internal change only

@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2022

⚠️ No Changeset found

Latest commit: be21ecf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Great to see this built into pnpm now 👍

Good to merge once the tests are green

@natemoo-re
Copy link
Member Author

I'm thinking this is an upstream issue? Perhaps the lockfile encodes the exact filesystem path of the patched packages.

@natemoo-re
Copy link
Member Author

Update: [email protected] did not fix it! I opened pnpm/pnpm#4961 to track.

@BlackHole1
Copy link

Hi folks👋. pnpm has been fixed and released version: 7.5.0. You can try it. 😃

Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like this has a really positive impatch!

@natemoo-re natemoo-re merged commit 0e01e0b into main Jul 7, 2022
@natemoo-re natemoo-re deleted the chore/pnpm-7.4.0 branch July 7, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants