-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: endpoints in dev server should never have trailing slash #10216
Conversation
🦋 Changeset detectedLatest commit: 4be7253 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e06619a
to
6400c29
Compare
6400c29
to
4be7253
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the changeset needs to be corrected, I think this is the wrong call.
Users should configure "trailingSlash" to inform the dev server that the production server will behave a certain way so it should too. If the behavior doesn't match, they may need to configure something else. trailingSlash
is doing what the config is telling it to.
Hm, that's a good point, let's chat about it. |
Test cases already exist in test/units/routing/trailing-slash.test.js, and check for the opposite behavior. |
I‘m afraid this issue still persists: #10149 (comment) Static File Endpoints exposing e.g. |
Changes
Closes #10149
Testing
Added a new test case. It seems we didn't have one.
Docs