fix: endpoints in dev server should never have trailing slash

.changeset/dry-suns-protect.md

@@ -0,0 +1,5 @@
+---
+"astro": patch
+---
+
+Fixes a regression where the dev server was returning a 404 when hitting an endpoint, when the app was configured with `trailingSlash: "always"`

packages/astro/src/core/routing/manifest/create.ts

@@ -383,7 +383,8 @@ function createFileBasedRoutes(
 			} else {
 				components.push(item.file);
 				const component = item.file;
-				const { trailingSlash } = settings.config;
+				// Endpoints should have trailing slash
+				const trailingSlash = item.isPage ? settings.config.trailingSlash : 'never';
 				const pattern = getPattern(segments, settings.config, trailingSlash);
 				const generate = getRouteGenerator(segments, trailingSlash);
 				const pathname = segments.every((segment) => segment.length === 1 && !segment[0].dynamic)

packages/astro/test/astro-endpoint.test.js

@@ -0,0 +1,23 @@
+import { before, it, after, describe } from 'node:test';
+import { loadFixture } from './test-utils.js';
+import assert from 'node:assert/strict';
+
+describe('Endpoint in dev, with trailing slash set to always', () => {
+	let fixture;
+	let devServer;
+
+	before(async () => {
+		fixture = await loadFixture({ root: './fixtures/astro-endpoint/' });
+		devServer = await fixture.startDevServer();
+	});
+
+	after(async () => {
+		await devServer.stop();
+	});
+
+	it('should render without issues', async () => {
+		let result = await fixture.fetch('/file.json');
+
+		assert.equal(result.status, 200);
+	});
+});

packages/astro/test/fixtures/astro-endpoint/astro.config.mjs

@@ -0,0 +1,6 @@
+import { defineConfig } from 'astro/config';
+
+// https://astro.build/config
+export default defineConfig({
+	trailingSlash: "always"
+});

packages/astro/test/fixtures/astro-endpoint/package.json

@@ -0,0 +1,8 @@
+{
+  "name": "@test/astro-endpoint",
+  "version": "0.0.0",
+  "private": true,
+  "dependencies": {
+    "astro": "workspace:*"
+  }
+}

packages/astro/test/fixtures/astro-endpoint/src/pages/file.json.js

@@ -0,0 +1 @@
+export const GET = () => Response.json({ success: true });