Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: navigation overhaul - WPB-6647 #1361

Open
wants to merge 1,096 commits into
base: chore/navigation-overhaul-cherry-picks-WPB-6647
Choose a base branch
from
Open

feat: navigation overhaul - WPB-6647 #1361

wants to merge 1,096 commits into from
+6,103 −5,276

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Apr 30, 2024 •
edited by github-actions bot
Loading

TopicWPB-6647 [iOS] Navigational Overhaul

Issue

Please describe the issue.

Optional: add details about technical approach, solutions etc.

Optional: reference dependencies to other pull requests etc.

Testing

Describe how to test.

Optional: attachments like images, videos, etc.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@caldrian caldrian marked this pull request as ready for review May 21, 2024 15:29
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 21, 2024 •
edited
Loading

Test Results

    5 files    578 suites   8m 53s ⏱️
4 376 tests 4 376 ✅ 0 💤 0 ❌
4 384 runs  4 384 ✅ 0 💤 0 ❌

Results for commit a892c2b.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented May 21, 2024 •
edited
Loading

Datadog Report

Branch report: epic/navigation-overhaul-WPB-6647
Commit report: f06faac
Test service: wire-ios-mono

✅ 0 Failed, 290 Passed, 0 Skipped, 1.31s Total Time

@agisilaos agisilaos changed the title epic: navigation overhaul [WPB-6647] feat: navigation overhaul [WPB-6647] May 24, 2024
@caldrian caldrian changed the title feat: navigation overhaul [WPB-6647] feat: navigation overhaul - WPB-6647 Jun 18, 2024
@wireapp wireapp deleted a comment from github-actions bot Jul 3, 2024
@wireapp wireapp deleted a comment from github-actions bot Jul 3, 2024
@wireapp wireapp deleted a comment from github-actions bot Jul 3, 2024
@wireapp wireapp deleted a comment from github-actions bot Jul 3, 2024
@wireapp wireapp deleted a comment from github-actions bot Jul 3, 2024
@wireapp wireapp deleted a comment from github-actions bot Jul 3, 2024
@wireapp wireapp deleted a comment from github-actions bot Jul 3, 2024
@wireapp wireapp deleted a comment from github-actions bot Jul 15, 2024
@wireapp wireapp deleted a comment from github-actions bot Jul 15, 2024
@wireapp wireapp deleted a comment from github-actions bot Jul 15, 2024
@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Aug 14, 2024
@samwyndham samwyndham mentioned this pull request Aug 16, 2024
Merged
3 tasks
@github-actions github-actions bot mentioned this pull request Aug 16, 2024
Merged
3 tasks
@echoes-hq echoes-hq bot added echoes: throughput/ci-maintenance Changes we need to do to keep CI healthy and fast echoes: features End-user visible changes intended to create customer value and removed echoes: features End-user visible changes intended to create customer value labels Sep 6, 2024
@echoes-hq echoes-hq bot added echoes: technical-debt Changes intended at mitigating risks echoes: maintenance Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements labels Sep 16, 2024
@caldrian
fix imports
a17924c
@caldrian
fix build error
9e1f79f
@caldrian
fix linter violations
5967172
@caldrian
add TODO
9d45b31
@caldrian
Merge branch 'chore/navigation-overhaul-cherry-picks-WPB-6647' into e…
e9bb899 
…pic/navigation-overhaul-WPB-6647
@caldrian
Merge branch 'epic/navigation-overhaul-WPB-6647' into fix/wire-ios-te…
04ecaad 
…sts-WPB-11346
@caldrian
fix tests
d15051f
@caldrian
update snapshot reference images
4a16ffb
@caldrian
Merge branch 'chore/navigation-overhaul-cherry-picks-WPB-6647' into f…
78b9b2b 
…eat/navigation-overhaul-WPB-6647
@caldrian
Merge branch 'feat/navigation-overhaul-WPB-6647' into fix/wire-ios-te…
d8f1f3f 
…sts-WPB-11346
@caldrian
Merge branch 'chore/navigation-overhaul-cherry-picks-WPB-6647' into f…
6a44935 
…eat/navigation-overhaul-WPB-6647
@caldrian
Merge branch 'feat/navigation-overhaul-WPB-6647' into fix/wire-ios-te…
04ed595 
…sts-WPB-11346
@caldrian caldrian changed the base branch from develop to chore/navigation-overhaul-cherry-picks-WPB-6647 October 15, 2024 16:13
@caldrian caldrian marked this pull request as ready for review October 16, 2024 07:17
@caldrian caldrian mentioned this pull request Oct 16, 2024
Open
6 tasks
caldrian and others added 12 commits October 16, 2024 13:34
@caldrian
Merge branch 'chore/navigation-overhaul-cherry-picks-WPB-6647' into e…
3bb544b 
…pic/navigation-overhaul-WPB-6647
@KaterinaWire
feat: empty state for conversation list - WPB-11341 (#2013)
7df6a1c
@caldrian
chore: pull develop and related pr - WPB-6647 (#2043)
01ae31c
@caldrian
Merge branch 'chore/navigation-overhaul-cherry-picks-WPB-6647' into f…
21ecad1 
…eat/navigation-overhaul-WPB-6647
@caldrian
Merge branch 'epic/navigation-overhaul-WPB-6647' of github.com:wireap…
cd776f2 
…p/wire-ios into epic/navigation-overhaul-WPB-6647
@caldrian
Merge branch 'feat/navigation-overhaul-WPB-6647' into epic/navigation…
9cdf017 
…-overhaul-WPB-6647
@caldrian
Merge branch 'chore/navigation-overhaul-cherry-picks-WPB-6647' into f…
30e7145 
…eat/navigation-overhaul-WPB-6647
@caldrian
Merge branch 'feat/navigation-overhaul-WPB-6647' into epic/navigation…
c2a0136 
…-overhaul-WPB-6647
@agisilaos
feat: New Design for Creating New Group Conversation Screen to match …
f65d121 
…Design Specs - WPB-11589 (#2036)
@caldrian
fix: call overlay and wrong navigation bar layout on iPad - WPB-11352 (…
f832354 
…#2052)
@agisilaos
chore: Delete CreateGuestRoomCell & CreateGroupCell - WPB-11612 (#…
584264a 
…2053)
@caldrian
fix: navigation bar layout when E2EI is enabled - WPB-11604 (#2054)
a892c2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netbe netbe Awaiting requested review from netbe

Assignees

@caldrian caldrian

Labels
echoes: features End-user visible changes intended to create customer value echoes: maintenance Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements echoes: technical-debt Changes intended at mitigating risks echoes: throughput/ci-maintenance Changes we need to do to keep CI healthy and fast LongLivingBranch Navigation Overhaul WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caldrian @netbe @KaterinaWire @agisilaos