Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navigation bar layout when E2EI is enabled - WPB-11604 #2054

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Oct 17, 2024

BugWPB-11604 [iOS] Wrong layout on iPad when E2EI enabled

Issue

This PR fixes an issue where the method for setting up the navigation bar of the conversation list for compact layout is also called for expanded layouts.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Oct 17, 2024
@caldrian caldrian merged commit a892c2b into epic/navigation-overhaul-WPB-6647 Oct 17, 2024
8 checks passed
@caldrian caldrian deleted the fix/navigation-bar-layout-E2EI-WPB-11604 branch October 17, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: features End-user visible changes intended to create customer value
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant