Moving to pypi version of realit-singer-python #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjsqu
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Hangs off the back of #75, which could not be pushed to PyPI using a GitHub reference. I am satisfied that the approach taken by @s7clarke10 to implement his own version of singer-python (repository that is 2 years stale) is the right course of action right now.
A larger piece of work to upgrade a Meltano SDK version of tap-mssql in the same manner is expected in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating tap-mssql to obtain singer-python from pypi realit-singer-python as local git version is not supported.