Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/patched singer python framework #75

Merged

Conversation

s7clarke10
Copy link
Collaborator

tap-mssql 2.4.0 2024-08-08

  • Moving to patched version of Singer Framework plus using msgspec rather than orjson for JSON serialization speed.
  • Adjusting tox file for test pipeline to point to correct location of the sqlcmd in the latest MSSQL docker image.
  • Adjusting tox file. Added -No switch calling sqlcmd to allow user/password connection to MSSQL.
  • Patching dependencies.
  • Pinned Requests to "2.31.0". This is required as the tox pipeline fails with a Docker API error with requests "2.32.x".
  • Explicitly setting python version 3.8 -> 3.12
  • Moving to using recommended poetry-core for build. https://python-poetry.org/docs/pyproject/#poetry-and-pep-517
  • NOTE: Recommend refactoring to avoid using tox-poetry-installer as restrictive dependencies are stopping tox and docker updates. This may resolve the requests/docker api issue.

@s7clarke10 s7clarke10 requested a review from mjsqu August 8, 2024 22:21
@s7clarke10 s7clarke10 self-assigned this Aug 8, 2024
Copy link
Collaborator

@mjsqu mjsqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great explanations for each of the required changes and the pipeline tests work fine now. Approved.

@mjsqu mjsqu merged commit 60db822 into wintersrd:master Aug 9, 2024
1 check passed
@s7clarke10 s7clarke10 deleted the feature/patched_singer_python_framework branch October 17, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants