Fix getting cookies from headers.

[gotgenes]

Fixes an issue in the API Gateway v2 adapter where the call to headers.raw() throws the following error:

TypeError: nodeResponse.headers.raw is not a function

As described in remix-run/remix#4354, the headers.raw() method is not available in the Headers class in Node.js. This change replaces the headers.raw() method with headers.entries() from the Fetch API to fix the issue.

Edit: The original approach used headers.getSetCookie(), but @wingleung informed me this is not available in Node 18. The original PR also included dependency updates, which I since removed.

[iradcn]

I'm experiencing this issue and would love to see this being merged!

[gotgenes]

@wingleung Is there anything I can do to help you review this PR?

[wingleung]

hey @gotgenes sorry for the late reply, thank you for the PR 🙏
the headers.getSetCookie() is only supported from node.js 19.7.0 and up, while remix still supports node 18 so I think we need to tweak it a little.

I see other solutions that use headers.entries() instead which offers support from node.js 18 and up
👉 https://github.com/remix-run/remix/pull/7150/files#diff-e37d9e295b178aa51a4880acae4b8bc7f82759e6868583513a5fa52b16846408

related to that, bumping the remix version in the peerDependencies might give unexpected behavior for some people who are on older versions of remix

[gotgenes]

@wingleung I updated the PR with your recommended changes. AFAICT this is working on the Node 20 Lambda runtime.

[wingleung]

@gotgenes just a question, how are you setting your headers?

When I test it locally with following loader function I get a set-cookie header for each letter of the value

export const loader: LoaderFunction = () => {
  const headers = new Headers();
  headers.append("Set-Cookie", "cookie1=cookie1Value");
  headers.append("Set-Cookie", "cookie2=cookie2Value");

  return json({}, {
    headers
  })
}

I believe we can remove the nested for loop here 👉 https://github.com/wingleung/remix-aws/pull/41/files#diff-6f39d6ba51b70c669d17f629bce999ac9f413e477a17f01ac8effd3f2d589c10L62
but I would like to know if there was another way of setting cookies that I'm missing here.

[gotgenes]

@wingleung I'm sorry, you're correct. I've updated the PR to remove that inner loop.

[wingleung]

@gotgenes thank you! 🙏 merged to develop and published a beta version 👉 1.3.0-beta.1