Remix should not rely on Response.headers.raw

[benmerckx]

What version of Remix are you using?

1.7.2

Steps to Reproduce

Any Response object that is created through other means than @remix-run/node (non node-fetch polyfills/undici/node builtins) fails here because Remix relies on the non standard Reponse.headers.raw:

remix/packages/remix-express/server.ts

Lines 125 to 129 in e260b2b

	for (let [key, values] of Object.entries(nodeResponse.headers.raw())) {
	for (let value of values) {
	res.append(key, value);
	}
	}

Expected Behavior

Remix should use the standard Response.headers interface to maximize compatibility, eg:

  for (let [key, value] of nodeResponse.headers.entries()) {
    res.append(key, value);
  }

Actual Behavior

Handing off a Response to Remix results in an error:

TypeError: nodeResponse.headers.raw is not a function
    at sendRemixResponse (C:\projects\alinea\examples\framework-remix\node_modules\@remix-run\express\dist\server.js:89:65)
    at C:\projects\alinea\examples\framework-remix\node_modules\@remix-run\express\dist\server.js:40:13
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

[kiliman]

I think they did it at one point due to an error in how duplicate headers were being handled in node-fetch. Headers like set-cookie were combined into a single header with comma-delimited values which was incorrect.

Now that Remix uses its own fetch implementation, I think we should go back to response.headers.entries()

[MoSattler]

This is causing problems when doing certain things with resource routes - e.g. handing GQL requests

[MichaelDeBoey]

Closed by #7150

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-1d3d86e-20230817 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 2.0.0-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!