chore(console): stop running playwright tests during build #3722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyrpex
requested review from
ainvoner,
polamoros,
eladcon and
a team
as code owners
polamoros
approved these changes
Aug 7, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Congrats! 🚀 This was released in Wing 0.24.78. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the
@wingconsole/app#testscript to@wingconsole/app#test:playwright, so it doesn't run with the root scriptsbuildortest. The problem is that in order to run Playwright tests, users need to runplaywright installorplaywright install --with-depsfirst, and may require sudo permissions.Additionally, moves the playwright tests from
tests/totest/, which is the standard directory for both playwright and our turbo configuration.Supersedes #3721.