fix(build): playwright cannot find browser executables in a new env #3721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyingImer
requested review from
ainvoner,
polamoros,
skyrpex and
eladcon
as code owners
Signed-off-by: monada-bot[bot] <[email protected]>
monadabot
added
the
⚠️ pr/review-mutation
|
Hey @flyingImer thanks for the PR. This is something I noticed from other people as well, and wanted to fix the issue. @polamoros and I checked out the solution you worked on and has a problem: in Ubuntu (and maybe other OS) the For now, I think the best solution is to rename the Console/App test to |
mergify bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
Renames the `@wingconsole/app#test` script to `@wingconsole/app#test:playwright`, so it doesn't run with the root scripts `build` or `test`. The problem is that in order to run Playwright tests, users need to run `playwright install` or `playwright install --with-deps` first, and may require sudo permissions. Additionally, moves the playwright tests from `tests/` to `test/`, which is the standard directory for both playwright and our turbo configuration. Supersedes #3721.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a new development environment,
pnpm buildfails due to missing browser deps for playwright tests with error messages like:It is required to install manually with
pnpm exec playwright installwithinapps/wing-console/console/app, which breaks thepnpm buildflow.This fix is a try to ensure the browser deps are always installed and being the latest before running tests. It works fine for local development. Although the installation "runs" before every test run, turbo does a pretty good job to cut corners:
Just not sure about if this is okay for the CI environment, please suggest
Checklist
pr/e2e-fulllabel if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.