Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce overwriteProvisionedServer when layers discovery is enabled #377

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Enforce overwriteProvisionedServer when layers discovery is enabled #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fd90d2
Enforce overwriteProvisionedServer when layers discovery is enabled
jfdenise Sep 11, 2023
3a76601
Bump to latest WildFly Glow
jfdenise Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions plugin/src/main/java/org/wildfly/plugin/dev/DevMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,10 @@ public class DevMojo extends AbstractServerStartMojo {
/**
* Set to {@code true} if you want to delete the existing server referenced from the {@code provisioningDir} and provision a
* new one,
* otherwise {@code false}.
* otherwise {@code false}. When { @code discover-provisioning-info } is set to {@code true}, this option is enforced to be
* {@code true}.
* When discovery of Galleon provisioning information is enabled, a change to the application source code
* could imply re-provisioning of the server.
*/
@Parameter(alias = "overwrite-provisioned-server", defaultValue = "false", property = PropertyNames.WILDFLY_PROVISIONING_OVERWRITE_PROVISIONED_SERVER)
private boolean overwriteProvisionedServer;
Expand Down Expand Up @@ -386,8 +389,8 @@ public void execute() throws MojoExecutionException, MojoFailureException {
} else {
if (isDiscoveryEnabled()) {
if (!overwriteProvisionedServer) {
throw new MojoExecutionException(
"When layer discovery is enabled, overwriteProvisionedServer must be set to true");
overwriteProvisionedServer = true;
getLog().info("Layer discovery has been enabled, overwriteProvisionedServer has been set to true");
}
} else {
context = startServer(ServerType.STANDALONE);
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@

<!-- galleon properties -->
<version.org.jboss.galleon>5.2.0.Final</version.org.jboss.galleon>
<version.org.wildfly.glow>1.0.0.Alpha1</version.org.wildfly.glow>
<version.org.wildfly.glow>1.0.0.Alpha4</version.org.wildfly.glow>
<plugin.fork.embedded>true</plugin.fork.embedded>
<!-- used by tests -->
<version.org.jboss.logging.slf4j-jboss-logging>1.2.1.Final</version.org.jboss.logging.slf4j-jboss-logging>
Expand Down