Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce overwriteProvisionedServer when layers discovery is enabled #377

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Enforce overwriteProvisionedServer when layers discovery is enabled #377

merged 2 commits into from
Sep 11, 2023

Conversation

jfdenise
Copy link
Contributor

No description provided.

@jfdenise jfdenise requested a review from jamezp as a code owner September 11, 2023 14:18
jmesnil
jmesnil approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@jmesnil jmesnil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 this ensures that the wildfly:dev goal will work out of the box when Glow is enabled

@jmesnil
Copy link
Member

jmesnil commented Sep 11, 2023

@jfdenise It might be worth adding a comment to

wildfly-maven-plugin/plugin/src/main/java/org/wildfly/plugin/dev/DevMojo.java

Line 319 in 9352aeb

@Parameter(alias = "overwrite-provisioned-server", defaultValue = "false", property = PropertyNames.WILDFLY_PROVISIONING_OVERWRITE_PROVISIONED_SERVER)
about this. wdyt?

@jfdenise
Copy link
Contributor Author

jfdenise commented Sep 11, 2023 •
edited
Loading

@jmesnil , thanks, comment added.

@jamezp jamezp merged commit 84fd9e1 into wildfly:main Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamezp jamezp jamezp approved these changes

@jmesnil jmesnil jmesnil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfdenise @jmesnil @jamezp