Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create missing rules for deprecated jQuery features #32

Open
12 of 15 tasks
edg2s opened this issue Dec 9, 2018 · 3 comments
Open
12 of 15 tasks

Create missing rules for deprecated jQuery features #32

edg2s opened this issue Dec 9, 2018 · 3 comments
Assignees

Comments

@edg2s
Copy link
Member

edg2s commented Dec 9, 2018

Listed as "FIXME" in index.js:

  • $.fx.interval
  • $(...).context
  • $.support
  • deferred.pipe()
  • $(...).error()
  • $(...).load(fn) (excluding $(...).load(url,...))
  • $(...).toggle(fn,fn) (excluding https://api.jquery.com/toggle/)
  • $(...).unload()
  • deferred.isRejected()/isResolved()
  • $.sub()
  • $(...).selector
  • $.boxModel
  • $.browser

Update from #52 and https://api.jquery.com/ready/:

  • $(...).ready() (3.0)
  • $(document).on( "ready", handler ) (1.8)
edg2s added a commit that referenced this issue Jan 21, 2019
…d-1.8

Also tweak no-event-shorthand rule to skip `$.method()`.

Part of #32
jdforrester pushed a commit that referenced this issue Jan 22, 2019
…d-1.8 (#51)

Also tweak no-event-shorthand rule to skip `$.method()`.

Part of #32
@edg2s
Copy link
Member Author

edg2s commented Jan 24, 2019

deferred.isRejected()/isResolved()

The only way to do this one is assume that in anyVariable.isRejected() the variable is a jQuery deferred. These names are somewhat unique, so a collision with a local method seems less likely. Projects that did have a local method with this name would probably have to disable the rule.

deferred.pipe on the other hand might be too common of a name.

edg2s added a commit that referenced this issue Jan 24, 2019
jdforrester pushed a commit that referenced this issue Jan 24, 2019
* Add no-on-ready rule and add to deprecated 1.8

Part of #32

* no-animate-on -> no-on-ready in test name
@edg2s edg2s mentioned this issue Jan 24, 2019
@edg2s
Copy link
Member Author

edg2s commented Jan 24, 2019

@Krinkle can you explain the difference between things that have been added to deprecated.js (https://github.com/jquery/jquery/commits/master/test/unit/deprecated.js), and things that are actually listed as deprecated in the docs, for example $.isArray was deprecated in 2016, but isn't listed as such anywhere.

@Krinkle
Copy link
Member

Krinkle commented Jun 20, 2020

@edg2s The only difference is time and effort spent to date :) - This has been fixed meanwhile (ref jquery/api.jquery.com#950).

@Krinkle Krinkle removed their assignment Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants