Add rule for no-ready-shorthand and include in deprecated-3.0

Part of #32 and #52

README.md

@@ -90,6 +90,7 @@ Alternatively, you can pick out rules individually:
     "jquery/no-prop": 2,
     "jquery/no-proxy": 2,
     "jquery/no-ready": 2,
+    "jquery/no-ready-shorthand": 2,
     "jquery/no-global-selector": 2,
     "jquery/no-serialize": 2,
     "jquery/no-show": 2,

index.js

@@ -51,6 +51,7 @@ module.exports = {
     'no-prop': require('./rules/no-prop'),
     'no-proxy': require('./rules/no-proxy'),
     'no-ready': require('./rules/no-ready'),
+    'no-ready-shorthand': require('./rules/no-ready-shorthand'),
     'no-serialize': require('./rules/no-serialize'),
     'no-global-selector': require('./rules/no-global-selector'),
     'no-show': require('./rules/no-show'),
@@ -93,6 +94,7 @@ module.exports = {
         'jquery/no-undelegate': 2,
         // FIXME: `$.fx.interval`
         'jquery/no-parse-json': 2,
+        'jquery/no-ready-shorthand': 2,
         'jquery/no-unique': 2
       }
     },

rules/no-ready-shorthand.js

@@ -0,0 +1,27 @@
+'use strict'
+
+const utils = require('./utils.js')
+
+module.exports = {
+  meta: {
+    docs: {},
+    schema: []
+  },
+
+  create: function(context) {
+    return {
+      CallExpression: function(node) {
+        if (node.callee.type !== 'MemberExpression') return
+        if (node.callee.object.name === '$') return
+        if (node.callee.property.name !== 'ready') return
+
+        if (utils.isjQuery(node)) {
+          context.report({
+            node: node,
+            message: 'Prefer $ to $.ready'
+          })
+        }
+      }
+    }
+  }
+}

tests/no-ready-shorthand.js

@@ -0,0 +1,37 @@
+'use strict'
+
+const rule = require('../rules/no-ready-shorthand')
+const RuleTester = require('eslint').RuleTester
+
+const error = 'Prefer $ to $.ready'
+
+const ruleTester = new RuleTester()
+ruleTester.run('no-ready-shorthand', rule, {
+  valid: [
+    'ready()',
+    '[].ready()',
+    'div.ready()',
+    'div.ready',
+    '$.ready()',
+    '$(document).on("ready", function(){})',
+    '$(function(){})'
+  ],
+  invalid: [
+    {
+      code: '$(document).ready()',
+      errors: [{message: error, type: 'CallExpression'}]
+    },
+    {
+      code: '$div.ready()',
+      errors: [{message: error, type: 'CallExpression'}]
+    },
+    {
+      code: '$("div").first().ready()',
+      errors: [{message: error, type: 'CallExpression'}]
+    },
+    {
+      code: '$("div").append($("input").ready())',
+      errors: [{message: error, type: 'CallExpression'}]
+    }
+  ]
+})