Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests and demos out of psignifit package #185

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

pberkes
Copy link
Collaborator

@pberkes pberkes commented Dec 16, 2024

Fix #128

@lschwetlick
Copy link
Collaborator

@guillermoaguilar I guess we will need to make sure to adjust the docs accordingly, because we are compiling those demos into the docs.

@otizonaizit
Copy link
Collaborator

@guillermoaguilar I guess we will need to make sure to adjust the docs accordingly, because we are compiling those demos into the docs.

well, as far as I understood from the discussion in #181 , those notebooks are jut waiting to be migrated into the new documentation created with jupyter-book, so they will be gone soon anyway. Otherwise the PR looks good to me!

@guillermoaguilar
Copy link
Collaborator

well, as far as I understood from the discussion in #181 , those notebooks are jut waiting to be migrated into the new documentation created with jupyter-book, so they will be gone soon anyway. Otherwise the PR looks good to me!

YES!

@pberkes pberkes force-pushed the move-tests-and-demos-out branch from 1d0c668 to b9e6110 Compare December 18, 2024 08:57
@pberkes
Copy link
Collaborator Author

pberkes commented Dec 18, 2024

I had to juggle a little because github was stopping me from merging, reporting a merge conflict that was not present when merging on the command line... anyway, now I merged manually and it looks alright

@pberkes pberkes merged commit 7ce66d6 into wichmann-lab:main Dec 18, 2024
6 checks passed
@pberkes pberkes deleted the move-tests-and-demos-out branch December 18, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conftest.py should be in tests folder
4 participants